feat(ecs): ability to access tag parameter value of TagParameterContainerImage #13340
Conversation
…inerImage Allows you to use the tag elsewhere within the container definition (e.g. to inform monitoring services of the release version). fixes: aws#13202
|
|
There was a problem hiding this comment.
Looks great @alastair-watts-avrios , thanks so much for the contribution!
Did you mark your PR as "Allows edits from contributors"? It's needed so that the Mergify bot can update your PR with master, and finally merge it in.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
| @@ -19,6 +19,21 @@ nodeunitShim({ | |||
| SynthUtils.synthesize(stack); | |||
| }, /TagParameterContainerImage must be used in a container definition when using tagParameterName/); | |||
|
|
|||
| test.done(); | |||
| }, | |||
There was a problem hiding this comment.
Can you add an empty line after this line?
| }, | |
| }, | |
|
@skinny85 |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Allows you to use the tag elsewhere within the container definition (e.g. to inform monitoring services of the release version).
Fixes: #13202
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license