Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(sns): additional validation for topic policy document #13617

Closed
MrArnoldPalmer opened this issue Mar 16, 2021 · 1 comment
Closed

(sns): additional validation for topic policy document #13617

MrArnoldPalmer opened this issue Mar 16, 2021 · 1 comment
Labels
@aws-cdk/aws-sns Related to Amazon Simple Notification Service closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. feature-request A feature should be added or improved. p2

Comments

@MrArnoldPalmer
Copy link
Contributor

There are a bunch of ways to create an sns TopicPolicy that will fail at deploy time. We should add additional validation to fail earlier and with more clear messaging to make usage easier.

https://docs.aws.amazon.com/sns/latest/dg/sns-access-policy-language-api-permissions-reference.html
@MrArnoldPalmer MrArnoldPalmer added p2 feature-request A feature should be added or improved. @aws-cdk/aws-sns Related to Amazon Simple Notification Service effort/small Small work item – less than a day of effort labels Mar 16, 2021
@MrArnoldPalmer MrArnoldPalmer mentioned this issue Mar 16, 2021
Closed
@ericzbeard ericzbeard added the feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. label Apr 1, 2021
@MrArnoldPalmer MrArnoldPalmer removed their assignment Jun 21, 2021
@github-actions
Copy link

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-sns Related to Amazon Simple Notification Service closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ericzbeard @MrArnoldPalmer