fix(s3): Notifications fail to deploy due to incompatible node runtime #13624

iliapolo · 2021-03-16T20:47:13Z

This PR upgraded our Node runtimes from 10 to 14. The problem is that Node14 isn't supported for lambda functions using inline code (i.e ZipFile).

Change to Node12 specifically for the notification handler since it's the only one using InlineLambda.

Fixes #13620

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

gitpod-io · 2021-03-16T20:47:19Z

aws-cdk-automation · 2021-03-16T22:15:58Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
Commit ID: 2723323
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2021-03-16T22:16:22Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

#13624) This [PR](#13488) upgraded our Node runtimes from `10` to `14`. The problem is that Node14 isn't supported for lambda functions using inline code (i.e `ZipFile`). Change to Node12 specifically for the notification handler since it's the only one using `InlineLambda`. Fixes #13620 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

[//]: # (dependabot-start) ⚠️ **Dependabot is rebasing this PR** ⚠️ If you make any changes to it yourself then they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [@aws-cdk/core](https://github.com/aws/aws-cdk/tree/HEAD/packages/@aws-cdk/core) from 1.93.0 to 1.94.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cdk/releases"><code>@aws-cdk/core's releases</code></a>.</em></p> <blockquote> <h2>v1.94.1</h2> <h3>Bug Fixes</h3> <ul> <li><strong>s3:</strong> Notifications fail to deploy due to incompatible node runtime (<a href="https://github.com/aws/aws-cdk/issues/13624">#13624</a>) (<a href="https://github.com/aws/aws-cdk/commit/26bc3d4951a96a4bdf3e3e10464a4e3b80ed563f">26bc3d4</a>)</li> </ul> <h2>v1.94.0</h2> <h3>⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES</h3> <ul> <li><strong>appmesh:</strong> Backend, backend default and Virtual Service client policies structures are being altered</li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualGateway</code>. The property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code></li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualNode</code>, (the property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code>), and the <code>Backend</code> class to define a backend</li> <li><strong>appmesh</strong>: you can no longer attach a client policy to a <code>VirtualService</code></li> </ul> <h3>Features</h3> <ul> <li><strong>appmesh:</strong> add missing route match features (<a href="https://github.com/aws/aws-cdk/issues/13350">#13350</a>) (<a href="https://github.com/aws/aws-cdk/commit/b71efd9d12843ab4b495d53e565cec97d60748f3">b71efd9</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11645">#11645</a></li> <li><strong>aws-elasticloadbalancingv2:</strong> add protocol version for ALB TargetGroups (<a href="https://github.com/aws/aws-cdk/issues/13570">#13570</a>) (<a href="https://github.com/aws/aws-cdk/commit/165a3d877b7ab23f29e42e1e74ee7c5cb35b7f24">165a3d8</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12869">#12869</a></li> <li><strong>ecs-patterns:</strong> Add ECS deployment circuit breaker support to higher-level constructs (<a href="https://github.com/aws/aws-cdk/issues/12719">#12719</a>) (<a href="https://github.com/aws/aws-cdk/commit/e80a98aa8839e9b9b89701158d82b991e9ebaa65">e80a98a</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12534">#12534</a> <a href="https://github.com/aws/aws-cdk/issues/12360">#12360</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>appmesh:</strong> Move Client Policy from Virtual Service to backend structure (<a href="https://github.com/aws/aws-cdk/issues/12943">#12943</a>) (<a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370">d3f4284</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11996">#11996</a></li> <li><strong>autoscaling:</strong> AutoScaling on percentile metrics doesn't work (<a href="https://github.com/aws/aws-cdk/issues/13366">#13366</a>) (<a href="https://github.com/aws/aws-cdk/commit/46114bb1f4702019a8873b9162d0a9f10763bc61">46114bb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13144">#13144</a></li> <li><strong>cloudwatch:</strong> cannot create Alarms from labeled metrics that start with a digit (<a href="https://github.com/aws/aws-cdk/issues/13560">#13560</a>) (<a href="https://github.com/aws/aws-cdk/commit/278029f25b41d956091835364e5a8de91429712c">278029f</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13434">#13434</a></li> <li>use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/issues/13488">#13488</a>) (<a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f">20a2820</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13534">#13534</a> <a href="https://github.com/aws/aws-cdk/issues/13484">#13484</a></li> <li><strong>ec2:</strong> Security Groups support all protocols (<a href="https://github.com/aws/aws-cdk/issues/13593">#13593</a>) (<a href="https://github.com/aws/aws-cdk/commit/8c6b3ebea464e27f68ffcab32857d8baec29c413">8c6b3eb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13403">#13403</a></li> <li><strong>lambda:</strong> fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/issues/13539">#13539</a>) (<a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad">77449f6</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13439">#13439</a></li> <li><strong>region-info:</strong> ap-northeast-3 data not correctly registered (<a href="https://github.com/aws/aws-cdk/issues/13564">#13564</a>) (<a href="https://github.com/aws/aws-cdk/commit/64da84be5c60bb8132551bcc27a7ca9c7effe95d">64da84b</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13561">#13561</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cdk/blob/master/CHANGELOG.md"><code>@aws-cdk/core's changelog</code></a>.</em></p> <blockquote> <h2><a href="https://github.com/aws/aws-cdk/compare/v1.94.0...v1.94.1">1.94.1</a> (2021-03-16)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>s3:</strong> Notifications fail to deploy due to incompatible node runtime (<a href="https://github.com/aws/aws-cdk/issues/13624">#13624</a>) (<a href="https://github.com/aws/aws-cdk/commit/26bc3d4951a96a4bdf3e3e10464a4e3b80ed563f">26bc3d4</a>)</li> </ul> <h2><a href="https://github.com/aws/aws-cdk/compare/v1.93.0...v1.94.0">1.94.0</a> (2021-03-16)</h2> <h3>⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES</h3> <ul> <li><strong>appmesh:</strong> Backend, backend default and Virtual Service client policies structures are being altered</li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualGateway</code>. The property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code></li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualNode</code>, (the property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code>), and the <code>Backend</code> class to define a backend</li> <li><strong>appmesh</strong>: you can no longer attach a client policy to a <code>VirtualService</code></li> </ul> <h3>Features</h3> <ul> <li><strong>appmesh:</strong> add missing route match features (<a href="https://github.com/aws/aws-cdk/issues/13350">#13350</a>) (<a href="https://github.com/aws/aws-cdk/commit/b71efd9d12843ab4b495d53e565cec97d60748f3">b71efd9</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11645">#11645</a></li> <li><strong>aws-elasticloadbalancingv2:</strong> add protocol version for ALB TargetGroups (<a href="https://github.com/aws/aws-cdk/issues/13570">#13570</a>) (<a href="https://github.com/aws/aws-cdk/commit/165a3d877b7ab23f29e42e1e74ee7c5cb35b7f24">165a3d8</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12869">#12869</a></li> <li><strong>ecs-patterns:</strong> Add ECS deployment circuit breaker support to higher-level constructs (<a href="https://github.com/aws/aws-cdk/issues/12719">#12719</a>) (<a href="https://github.com/aws/aws-cdk/commit/e80a98aa8839e9b9b89701158d82b991e9ebaa65">e80a98a</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12534">#12534</a> <a href="https://github.com/aws/aws-cdk/issues/12360">#12360</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>appmesh:</strong> Move Client Policy from Virtual Service to backend structure (<a href="https://github.com/aws/aws-cdk/issues/12943">#12943</a>) (<a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370">d3f4284</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11996">#11996</a></li> <li><strong>autoscaling:</strong> AutoScaling on percentile metrics doesn't work (<a href="https://github.com/aws/aws-cdk/issues/13366">#13366</a>) (<a href="https://github.com/aws/aws-cdk/commit/46114bb1f4702019a8873b9162d0a9f10763bc61">46114bb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13144">#13144</a></li> <li><strong>cloudwatch:</strong> cannot create Alarms from labeled metrics that start with a digit (<a href="https://github.com/aws/aws-cdk/issues/13560">#13560</a>) (<a href="https://github.com/aws/aws-cdk/commit/278029f25b41d956091835364e5a8de91429712c">278029f</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13434">#13434</a></li> <li>use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/issues/13488">#13488</a>) (<a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f">20a2820</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13534">#13534</a> <a href="https://github.com/aws/aws-cdk/issues/13484">#13484</a></li> <li><strong>ec2:</strong> Security Groups support all protocols (<a href="https://github.com/aws/aws-cdk/issues/13593">#13593</a>) (<a href="https://github.com/aws/aws-cdk/commit/8c6b3ebea464e27f68ffcab32857d8baec29c413">8c6b3eb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13403">#13403</a></li> <li><strong>lambda:</strong> fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/issues/13539">#13539</a>) (<a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad">77449f6</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13439">#13439</a></li> <li><strong>region-info:</strong> ap-northeast-3 data not correctly registered (<a href="https://github.com/aws/aws-cdk/issues/13564">#13564</a>) (<a href="https://github.com/aws/aws-cdk/commit/64da84be5c60bb8132551bcc27a7ca9c7effe95d">64da84b</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13561">#13561</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/aws/aws-cdk/commits/v1.94.1/packages/@aws-cdk/core">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@aws-cdk/core&package-manager=npm_and_yarn&previous-version=1.93.0&new-version=1.94.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually </details>

[//]: # (dependabot-start) ⚠️ **Dependabot is rebasing this PR** ⚠️ If you make any changes to it yourself then they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [aws-cdk](https://github.com/aws/aws-cdk/tree/HEAD/packages/aws-cdk) from 1.93.0 to 1.94.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cdk/releases">aws-cdk's releases</a>.</em></p> <blockquote> <h2>v1.94.1</h2> <h3>Bug Fixes</h3> <ul> <li><strong>s3:</strong> Notifications fail to deploy due to incompatible node runtime (<a href="https://github.com/aws/aws-cdk/issues/13624">#13624</a>) (<a href="https://github.com/aws/aws-cdk/commit/26bc3d4951a96a4bdf3e3e10464a4e3b80ed563f">26bc3d4</a>)</li> </ul> <h2>v1.94.0</h2> <h3>⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES</h3> <ul> <li><strong>appmesh:</strong> Backend, backend default and Virtual Service client policies structures are being altered</li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualGateway</code>. The property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code></li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualNode</code>, (the property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code>), and the <code>Backend</code> class to define a backend</li> <li><strong>appmesh</strong>: you can no longer attach a client policy to a <code>VirtualService</code></li> </ul> <h3>Features</h3> <ul> <li><strong>appmesh:</strong> add missing route match features (<a href="https://github.com/aws/aws-cdk/issues/13350">#13350</a>) (<a href="https://github.com/aws/aws-cdk/commit/b71efd9d12843ab4b495d53e565cec97d60748f3">b71efd9</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11645">#11645</a></li> <li><strong>aws-elasticloadbalancingv2:</strong> add protocol version for ALB TargetGroups (<a href="https://github.com/aws/aws-cdk/issues/13570">#13570</a>) (<a href="https://github.com/aws/aws-cdk/commit/165a3d877b7ab23f29e42e1e74ee7c5cb35b7f24">165a3d8</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12869">#12869</a></li> <li><strong>ecs-patterns:</strong> Add ECS deployment circuit breaker support to higher-level constructs (<a href="https://github.com/aws/aws-cdk/issues/12719">#12719</a>) (<a href="https://github.com/aws/aws-cdk/commit/e80a98aa8839e9b9b89701158d82b991e9ebaa65">e80a98a</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12534">#12534</a> <a href="https://github.com/aws/aws-cdk/issues/12360">#12360</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>appmesh:</strong> Move Client Policy from Virtual Service to backend structure (<a href="https://github.com/aws/aws-cdk/issues/12943">#12943</a>) (<a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370">d3f4284</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11996">#11996</a></li> <li><strong>autoscaling:</strong> AutoScaling on percentile metrics doesn't work (<a href="https://github.com/aws/aws-cdk/issues/13366">#13366</a>) (<a href="https://github.com/aws/aws-cdk/commit/46114bb1f4702019a8873b9162d0a9f10763bc61">46114bb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13144">#13144</a></li> <li><strong>cloudwatch:</strong> cannot create Alarms from labeled metrics that start with a digit (<a href="https://github.com/aws/aws-cdk/issues/13560">#13560</a>) (<a href="https://github.com/aws/aws-cdk/commit/278029f25b41d956091835364e5a8de91429712c">278029f</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13434">#13434</a></li> <li>use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/issues/13488">#13488</a>) (<a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f">20a2820</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13534">#13534</a> <a href="https://github.com/aws/aws-cdk/issues/13484">#13484</a></li> <li><strong>ec2:</strong> Security Groups support all protocols (<a href="https://github.com/aws/aws-cdk/issues/13593">#13593</a>) (<a href="https://github.com/aws/aws-cdk/commit/8c6b3ebea464e27f68ffcab32857d8baec29c413">8c6b3eb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13403">#13403</a></li> <li><strong>lambda:</strong> fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/issues/13539">#13539</a>) (<a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad">77449f6</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13439">#13439</a></li> <li><strong>region-info:</strong> ap-northeast-3 data not correctly registered (<a href="https://github.com/aws/aws-cdk/issues/13564">#13564</a>) (<a href="https://github.com/aws/aws-cdk/commit/64da84be5c60bb8132551bcc27a7ca9c7effe95d">64da84b</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13561">#13561</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cdk/blob/master/CHANGELOG.md">aws-cdk's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/aws/aws-cdk/compare/v1.94.0...v1.94.1">1.94.1</a> (2021-03-16)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>s3:</strong> Notifications fail to deploy due to incompatible node runtime (<a href="https://github.com/aws/aws-cdk/issues/13624">#13624</a>) (<a href="https://github.com/aws/aws-cdk/commit/26bc3d4951a96a4bdf3e3e10464a4e3b80ed563f">26bc3d4</a>)</li> </ul> <h2><a href="https://github.com/aws/aws-cdk/compare/v1.93.0...v1.94.0">1.94.0</a> (2021-03-16)</h2> <h3>⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES</h3> <ul> <li><strong>appmesh:</strong> Backend, backend default and Virtual Service client policies structures are being altered</li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualGateway</code>. The property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code></li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualNode</code>, (the property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code>), and the <code>Backend</code> class to define a backend</li> <li><strong>appmesh</strong>: you can no longer attach a client policy to a <code>VirtualService</code></li> </ul> <h3>Features</h3> <ul> <li><strong>appmesh:</strong> add missing route match features (<a href="https://github.com/aws/aws-cdk/issues/13350">#13350</a>) (<a href="https://github.com/aws/aws-cdk/commit/b71efd9d12843ab4b495d53e565cec97d60748f3">b71efd9</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11645">#11645</a></li> <li><strong>aws-elasticloadbalancingv2:</strong> add protocol version for ALB TargetGroups (<a href="https://github.com/aws/aws-cdk/issues/13570">#13570</a>) (<a href="https://github.com/aws/aws-cdk/commit/165a3d877b7ab23f29e42e1e74ee7c5cb35b7f24">165a3d8</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12869">#12869</a></li> <li><strong>ecs-patterns:</strong> Add ECS deployment circuit breaker support to higher-level constructs (<a href="https://github.com/aws/aws-cdk/issues/12719">#12719</a>) (<a href="https://github.com/aws/aws-cdk/commit/e80a98aa8839e9b9b89701158d82b991e9ebaa65">e80a98a</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12534">#12534</a> <a href="https://github.com/aws/aws-cdk/issues/12360">#12360</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>appmesh:</strong> Move Client Policy from Virtual Service to backend structure (<a href="https://github.com/aws/aws-cdk/issues/12943">#12943</a>) (<a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370">d3f4284</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11996">#11996</a></li> <li><strong>autoscaling:</strong> AutoScaling on percentile metrics doesn't work (<a href="https://github.com/aws/aws-cdk/issues/13366">#13366</a>) (<a href="https://github.com/aws/aws-cdk/commit/46114bb1f4702019a8873b9162d0a9f10763bc61">46114bb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13144">#13144</a></li> <li><strong>cloudwatch:</strong> cannot create Alarms from labeled metrics that start with a digit (<a href="https://github.com/aws/aws-cdk/issues/13560">#13560</a>) (<a href="https://github.com/aws/aws-cdk/commit/278029f25b41d956091835364e5a8de91429712c">278029f</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13434">#13434</a></li> <li>use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/issues/13488">#13488</a>) (<a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f">20a2820</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13534">#13534</a> <a href="https://github.com/aws/aws-cdk/issues/13484">#13484</a></li> <li><strong>ec2:</strong> Security Groups support all protocols (<a href="https://github.com/aws/aws-cdk/issues/13593">#13593</a>) (<a href="https://github.com/aws/aws-cdk/commit/8c6b3ebea464e27f68ffcab32857d8baec29c413">8c6b3eb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13403">#13403</a></li> <li><strong>lambda:</strong> fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/issues/13539">#13539</a>) (<a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad">77449f6</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13439">#13439</a></li> <li><strong>region-info:</strong> ap-northeast-3 data not correctly registered (<a href="https://github.com/aws/aws-cdk/issues/13564">#13564</a>) (<a href="https://github.com/aws/aws-cdk/commit/64da84be5c60bb8132551bcc27a7ca9c7effe95d">64da84b</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13561">#13561</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/aws/aws-cdk/commits/v1.94.1/packages/aws-cdk">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=aws-cdk&package-manager=npm_and_yarn&previous-version=1.93.0&new-version=1.94.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually </details>

[//]: # (dependabot-start) ⚠️ **Dependabot is rebasing this PR** ⚠️ If you make any changes to it yourself then they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [@aws-cdk/assert](https://github.com/aws/aws-cdk/tree/HEAD/packages/@aws-cdk/assert) from 1.93.0 to 1.94.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cdk/releases"><code>@aws-cdk/assert's releases</code></a>.</em></p> <blockquote> <h2>v1.94.1</h2> <h3>Bug Fixes</h3> <ul> <li><strong>s3:</strong> Notifications fail to deploy due to incompatible node runtime (<a href="https://github.com/aws/aws-cdk/issues/13624">#13624</a>) (<a href="https://github.com/aws/aws-cdk/commit/26bc3d4951a96a4bdf3e3e10464a4e3b80ed563f">26bc3d4</a>)</li> </ul> <h2>v1.94.0</h2> <h3>⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES</h3> <ul> <li><strong>appmesh:</strong> Backend, backend default and Virtual Service client policies structures are being altered</li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualGateway</code>. The property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code></li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualNode</code>, (the property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code>), and the <code>Backend</code> class to define a backend</li> <li><strong>appmesh</strong>: you can no longer attach a client policy to a <code>VirtualService</code></li> </ul> <h3>Features</h3> <ul> <li><strong>appmesh:</strong> add missing route match features (<a href="https://github.com/aws/aws-cdk/issues/13350">#13350</a>) (<a href="https://github.com/aws/aws-cdk/commit/b71efd9d12843ab4b495d53e565cec97d60748f3">b71efd9</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11645">#11645</a></li> <li><strong>aws-elasticloadbalancingv2:</strong> add protocol version for ALB TargetGroups (<a href="https://github.com/aws/aws-cdk/issues/13570">#13570</a>) (<a href="https://github.com/aws/aws-cdk/commit/165a3d877b7ab23f29e42e1e74ee7c5cb35b7f24">165a3d8</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12869">#12869</a></li> <li><strong>ecs-patterns:</strong> Add ECS deployment circuit breaker support to higher-level constructs (<a href="https://github.com/aws/aws-cdk/issues/12719">#12719</a>) (<a href="https://github.com/aws/aws-cdk/commit/e80a98aa8839e9b9b89701158d82b991e9ebaa65">e80a98a</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12534">#12534</a> <a href="https://github.com/aws/aws-cdk/issues/12360">#12360</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>appmesh:</strong> Move Client Policy from Virtual Service to backend structure (<a href="https://github.com/aws/aws-cdk/issues/12943">#12943</a>) (<a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370">d3f4284</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11996">#11996</a></li> <li><strong>autoscaling:</strong> AutoScaling on percentile metrics doesn't work (<a href="https://github.com/aws/aws-cdk/issues/13366">#13366</a>) (<a href="https://github.com/aws/aws-cdk/commit/46114bb1f4702019a8873b9162d0a9f10763bc61">46114bb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13144">#13144</a></li> <li><strong>cloudwatch:</strong> cannot create Alarms from labeled metrics that start with a digit (<a href="https://github.com/aws/aws-cdk/issues/13560">#13560</a>) (<a href="https://github.com/aws/aws-cdk/commit/278029f25b41d956091835364e5a8de91429712c">278029f</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13434">#13434</a></li> <li>use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/issues/13488">#13488</a>) (<a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f">20a2820</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13534">#13534</a> <a href="https://github.com/aws/aws-cdk/issues/13484">#13484</a></li> <li><strong>ec2:</strong> Security Groups support all protocols (<a href="https://github.com/aws/aws-cdk/issues/13593">#13593</a>) (<a href="https://github.com/aws/aws-cdk/commit/8c6b3ebea464e27f68ffcab32857d8baec29c413">8c6b3eb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13403">#13403</a></li> <li><strong>lambda:</strong> fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/issues/13539">#13539</a>) (<a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad">77449f6</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13439">#13439</a></li> <li><strong>region-info:</strong> ap-northeast-3 data not correctly registered (<a href="https://github.com/aws/aws-cdk/issues/13564">#13564</a>) (<a href="https://github.com/aws/aws-cdk/commit/64da84be5c60bb8132551bcc27a7ca9c7effe95d">64da84b</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13561">#13561</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cdk/blob/master/CHANGELOG.md"><code>@aws-cdk/assert's changelog</code></a>.</em></p> <blockquote> <h2><a href="https://github.com/aws/aws-cdk/compare/v1.94.0...v1.94.1">1.94.1</a> (2021-03-16)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>s3:</strong> Notifications fail to deploy due to incompatible node runtime (<a href="https://github.com/aws/aws-cdk/issues/13624">#13624</a>) (<a href="https://github.com/aws/aws-cdk/commit/26bc3d4951a96a4bdf3e3e10464a4e3b80ed563f">26bc3d4</a>)</li> </ul> <h2><a href="https://github.com/aws/aws-cdk/compare/v1.93.0...v1.94.0">1.94.0</a> (2021-03-16)</h2> <h3>⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES</h3> <ul> <li><strong>appmesh:</strong> Backend, backend default and Virtual Service client policies structures are being altered</li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualGateway</code>. The property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code></li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualNode</code>, (the property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code>), and the <code>Backend</code> class to define a backend</li> <li><strong>appmesh</strong>: you can no longer attach a client policy to a <code>VirtualService</code></li> </ul> <h3>Features</h3> <ul> <li><strong>appmesh:</strong> add missing route match features (<a href="https://github.com/aws/aws-cdk/issues/13350">#13350</a>) (<a href="https://github.com/aws/aws-cdk/commit/b71efd9d12843ab4b495d53e565cec97d60748f3">b71efd9</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11645">#11645</a></li> <li><strong>aws-elasticloadbalancingv2:</strong> add protocol version for ALB TargetGroups (<a href="https://github.com/aws/aws-cdk/issues/13570">#13570</a>) (<a href="https://github.com/aws/aws-cdk/commit/165a3d877b7ab23f29e42e1e74ee7c5cb35b7f24">165a3d8</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12869">#12869</a></li> <li><strong>ecs-patterns:</strong> Add ECS deployment circuit breaker support to higher-level constructs (<a href="https://github.com/aws/aws-cdk/issues/12719">#12719</a>) (<a href="https://github.com/aws/aws-cdk/commit/e80a98aa8839e9b9b89701158d82b991e9ebaa65">e80a98a</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12534">#12534</a> <a href="https://github.com/aws/aws-cdk/issues/12360">#12360</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>appmesh:</strong> Move Client Policy from Virtual Service to backend structure (<a href="https://github.com/aws/aws-cdk/issues/12943">#12943</a>) (<a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370">d3f4284</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11996">#11996</a></li> <li><strong>autoscaling:</strong> AutoScaling on percentile metrics doesn't work (<a href="https://github.com/aws/aws-cdk/issues/13366">#13366</a>) (<a href="https://github.com/aws/aws-cdk/commit/46114bb1f4702019a8873b9162d0a9f10763bc61">46114bb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13144">#13144</a></li> <li><strong>cloudwatch:</strong> cannot create Alarms from labeled metrics that start with a digit (<a href="https://github.com/aws/aws-cdk/issues/13560">#13560</a>) (<a href="https://github.com/aws/aws-cdk/commit/278029f25b41d956091835364e5a8de91429712c">278029f</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13434">#13434</a></li> <li>use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/issues/13488">#13488</a>) (<a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f">20a2820</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13534">#13534</a> <a href="https://github.com/aws/aws-cdk/issues/13484">#13484</a></li> <li><strong>ec2:</strong> Security Groups support all protocols (<a href="https://github.com/aws/aws-cdk/issues/13593">#13593</a>) (<a href="https://github.com/aws/aws-cdk/commit/8c6b3ebea464e27f68ffcab32857d8baec29c413">8c6b3eb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13403">#13403</a></li> <li><strong>lambda:</strong> fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/issues/13539">#13539</a>) (<a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad">77449f6</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13439">#13439</a></li> <li><strong>region-info:</strong> ap-northeast-3 data not correctly registered (<a href="https://github.com/aws/aws-cdk/issues/13564">#13564</a>) (<a href="https://github.com/aws/aws-cdk/commit/64da84be5c60bb8132551bcc27a7ca9c7effe95d">64da84b</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13561">#13561</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/aws/aws-cdk/commits/v1.94.1/packages/@aws-cdk/assert">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@aws-cdk/assert&package-manager=npm_and_yarn&previous-version=1.93.0&new-version=1.94.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually </details>

aws#13624) This [PR](aws#13488) upgraded our Node runtimes from `10` to `14`. The problem is that Node14 isn't supported for lambda functions using inline code (i.e `ZipFile`). Change to Node12 specifically for the notification handler since it's the only one using `InlineLambda`. Fixes aws#13620 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

revert notification handler to node12

58937a6

github-actions bot added the @aws-cdk/aws-s3 Related to Amazon S3 label Mar 16, 2021

github-actions bot assigned iliapolo Mar 16, 2021

mergify bot added the contribution/core This is a PR that came from AWS. label Mar 16, 2021

iliapolo requested a review from a team March 16, 2021 20:48

skinny85 approved these changes Mar 16, 2021

View reviewed changes

iliapolo mentioned this pull request Mar 16, 2021

‼️ NOTICE: S3 notifications fail to deploy on version 1.94.0 - ZipFile can only be used when Runtime is set to either of nodejs8.10... #13620

Closed

more integ tests

2723323

mergify bot merged commit aa32cf6 into master Mar 16, 2021

mergify bot deleted the epolon/fix-inline-lambda-node-runtime branch March 16, 2021 22:16

This was referenced Mar 17, 2021

chore(deps): Bump @aws-cdk/aws-s3 from 1.93.0 to 1.94.1 SnapPetal/cdk-simplewebsite-deploy#156

Closed

Bump aws-cdk from 1.76.0 to 1.94.1 covertbert/shared-aws-infra#143

Closed

dependabot bot mentioned this pull request Mar 17, 2021

build(deps): bump @aws-cdk/core from 1.93.0 to 1.94.1 wheatstalk/oidc-mock#14

Closed

This was referenced Mar 18, 2021

build(deps-dev): bump @aws-cdk/aws-ec2 from 1.92.0 to 1.94.1 superluminar-io/super-eks#99

Closed

build(deps-dev): bump @aws-cdk/aws-iam from 1.92.0 to 1.94.1 superluminar-io/super-eks#103

Closed

nija-at mentioned this pull request Mar 23, 2021

BucketNotificationsHandler lambda cannot be deployed #13635

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(s3): Notifications fail to deploy due to incompatible node runtime #13624

fix(s3): Notifications fail to deploy due to incompatible node runtime #13624

iliapolo commented Mar 16, 2021 •

edited

Loading

gitpod-io bot commented Mar 16, 2021 •

edited

Loading

aws-cdk-automation commented Mar 16, 2021

mergify bot commented Mar 16, 2021

fix(s3): Notifications fail to deploy due to incompatible node runtime #13624

fix(s3): Notifications fail to deploy due to incompatible node runtime #13624

Conversation

iliapolo commented Mar 16, 2021 • edited Loading

gitpod-io bot commented Mar 16, 2021 • edited Loading

aws-cdk-automation commented Mar 16, 2021

AWS CodeBuild CI Report

mergify bot commented Mar 16, 2021

iliapolo commented Mar 16, 2021 •

edited

Loading

gitpod-io bot commented Mar 16, 2021 •

edited

Loading