fix(rds): fail with a descriptive error if Cluster's instance count is a deploy-time value #13765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
@aws-cdk/aws-rds
|
@skinny85 Please review |
skinny85
previously requested changes
Mar 24, 2021
| @@ -651,6 +651,9 @@ interface InstanceConfig { | |||
| */ | |||
| function createInstances(cluster: DatabaseClusterNew, props: DatabaseClusterBaseProps, subnetGroup: ISubnetGroup): InstanceConfig { | |||
| const instanceCount = props.instances != null ? props.instances : 2; | |||
| if (Token.isUnresolved(instanceCount)) { | |||
| throw new Error('Instance count is not a token'); | |||
There was a problem hiding this comment.
This error message needs to be better here. Maybe something like:
Suggested change
| throw new Error('Instance count is not a token'); | |
| throw new Error('The number of instances an RDS Cluster consists of cannot be provided as a deploy-time only value!'); |
skinny85
changed the title
|
@skinny85 Made the requested changes. Please review |
… a deploy-time value fixes aws#13558
|
@skinny85 Build fails |
skinny85
approved these changes
Mar 26, 2021
thanks :) |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a condition to check whether the
instanceCountis a token or not. If it's not a token then an exception will be thrown.Fixes #13558
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license