Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudWatch alarm is missing metrics: MetricDataQuery[] field #1388

Closed
sam-goodwin opened this issue Dec 18, 2018 · 2 comments · Fixed by #1959
Closed

CloudWatch alarm is missing metrics: MetricDataQuery[] field #1388

sam-goodwin opened this issue Dec 18, 2018 · 2 comments · Fixed by #1959
Labels
@aws-cdk/aws-cloudwatch Related to Amazon CloudWatch

Comments

@sam-goodwin
Copy link
Contributor

The CfnAlarm L1 resource is missing the metrics: MetricDataQuery[] field described here: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cw-alarm.html#cfn-cloudwatch-alarm-metrics

Current generated CfnAlarmProps interface:

/**
 * @link http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cw-alarm.html
 */
export interface CfnAlarmProps {
    comparisonOperator: string | cdk.Token;
    evaluationPeriods: number | cdk.Token;
    threshold: number | cdk.Token;
    actionsEnabled?: boolean | cdk.Token;
    alarmActions?: Array<string | cdk.Token> | cdk.Token;
    alarmDescription?: string | cdk.Token;
    alarmName?: string | cdk.Token;
    datapointsToAlarm?: number | cdk.Token;
    dimensions?: Array<CfnAlarm.DimensionProperty | cdk.Token> | cdk.Token;
    evaluateLowSampleCountPercentile?: string | cdk.Token;
    extendedStatistic?: string | cdk.Token;
    insufficientDataActions?: Array<string | cdk.Token> | cdk.Token;
    metricName?: string | cdk.Token;
    // Where is metrics?: MetricDataQuery[];
    namespace?: string | cdk.Token;
    okActions?: Array<string | cdk.Token> | cdk.Token;
    period?: number | cdk.Token;
    statistic?: string | cdk.Token;
    treatMissingData?: string | cdk.Token;
    unit?: string | cdk.Token;
}
@sam-goodwin sam-goodwin added bug This issue is a bug. @aws-cdk/aws-cloudwatch Related to Amazon CloudWatch labels Dec 18, 2018
@sam-goodwin
Copy link
Contributor Author

This isn't an issue with the CDK, the definitions are missing from the specification: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/cfn-resource-specification.html

@rix0rrr rix0rrr added gap and removed gap labels Jan 4, 2019
@eladb eladb removed the bug This issue is a bug. label Jan 7, 2019
@davidbarsky
Copy link

I'm running into this issue—getting this fixed until #1396 lands could unblock some use-cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-cloudwatch Related to Amazon CloudWatch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants