feat(s3-deployment): graduate to stable 🚀 #13906
Conversation
| @@ -70,6 +64,37 @@ By default, the contents of the destination bucket will **not** be deleted when | |||
| changed. You can use the option `retainOnDelete: false` to disable this behavior, | |||
| in which case the contents will be deleted. | |||
|
|
|||
| Configuring this has a few implications you should be aware of: | |||
There was a problem hiding this comment.
I considered dropping this feature entirely due to these, and instead instruct users to use autoDeleteObjects on the destination bucket.
The problem is that autoDeleteObjects doesn't respect prefixes (nor it should), so its going to delete the entire bucket, while retainOnDelete: false only deletes the specified prefix that it was configured with.
Since our default is true, and we haven't seen any users report these issues, it's probably ok to just surface them a bit and leave as is.
|
|
iliapolo
added
the
pr-linter/exempt-test
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Also fixed up some lint violations just for fun. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Also fixed up some lint violations just for fun.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license