-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(appmesh): Implement Outlier Detection for Virtual Nodes #13952
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @alexbrjo , just one small question.
You wrote in a comment:
// Cloud Map service discovery is currently required for host ejection by outlier detection
I wonder - is this something we want to validate on the CDK side of things, or do you expect this limitation to be lifted soon?
Yeah I considered throwing an error but after discussing with the team decided to leave it out. We have a feature request that would support non-CloudMap outlier detection aws/aws-app-mesh-roadmap#239 |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This is a pretty short PR adding outlier detection to Virtual Node listeners. See below for usage. ```ts const node = mesh.addVirtualNode('virtual-node', { serviceDiscovery: appmesh.ServiceDiscovery.cloudMap({ service: service, }), outlierDetection: { baseEjectionDuration: cdk.Duration.seconds(10), interval: cdk.Duration.seconds(30), maxEjectionPercent: 50, maxServerErrors: 5, }, }); ``` Note: * All the parameters are required and there aren't any combinations of features that get special treatment, so there's only one unit test. * We don't do any min/max time evaluation for other features so I followed precedent for that. issue aws#11648 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This is a pretty short PR adding outlier detection to Virtual Node listeners. See below for usage.
Note:
issue #11648
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license