Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap s3 bucket: add lifecycle policy option #13968

Closed
kjpgit opened this issue Apr 2, 2021 · 2 comments
Closed

bootstrap s3 bucket: add lifecycle policy option #13968

kjpgit opened this issue Apr 2, 2021 · 2 comments
Assignees
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. package/tools Related to AWS CDK Tools or CLI

Comments

@kjpgit
Copy link

kjpgit commented Apr 2, 2021

I looked at the bootstrap template and am unsure if it's safe to add a lifecycle policy to the staging s3 bucket to delete objects after 7 days or even 1 day.
https://github.com/aws/aws-cdk/blob/master/packages/aws-cdk/lib/api/bootstrap/bootstrap-template.yaml

It would be helpful if there was an option or at least a comment saying if this is safe to do, and frankly I'm not sure why it's not the default. Isn't 100 trillion objects in S3 enough for you guys? Are these assets needed for more than a day, to handle stack deploys?

@kjpgit kjpgit added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 2, 2021
@github-actions github-actions bot added the @aws-cdk/aws-s3 Related to Amazon S3 label Apr 2, 2021
@iliapolo iliapolo assigned rix0rrr and unassigned iliapolo Apr 5, 2021
@iliapolo iliapolo added package/tools Related to AWS CDK Tools or CLI and removed @aws-cdk/aws-s3 Related to Amazon S3 labels Apr 5, 2021
@NetaNir
Copy link
Contributor

NetaNir commented Apr 6, 2021

The bootstrap bucket is used for several other Assets such as Lambda runtime code. We are considering adding some from of Assets garbage collection to address this, you can read more about in this issue on the CDK RFC repo.

In the meantime you can customize the bootstrap template by using the --template option.

@NetaNir NetaNir closed this as completed Apr 6, 2021
@github-actions
Copy link

github-actions bot commented Apr 6, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

No branches or pull requests

4 participants