feat(codepipeline): introduce the Action abstract class #14009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
@aws-cdk/aws-codepipeline
skinny85
force-pushed
the
fix/codepipeline-action-public
branch
2 times, most recently
from
8a97159 to
c2b26ff
Compare
rix0rrr
requested changes
Apr 9, 2021
Add an officially supported class to the API of the CodePipeline module that contains some logic common to all implementations of the `IAction` interface, like dealing with variable namespaces, or methods like `onStateChange()`. Make the experimental class in codepipeline-actions with the same name extend this new class, and make it stable.
skinny85
force-pushed
the
fix/codepipeline-action-public
branch
from
c2b26ff to
be22cc8
Compare
|
@rix0rrr incorporated your comments, would appreciate a re-review! |
rix0rrr
approved these changes
Apr 13, 2021
skinny85
added
the
pr-linter/exempt-readme
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
Add an officially supported class to the API of the CodePipeline module that contains some logic common to all implementations of the `IAction` interface, like dealing with variable namespaces, or methods like `onStateChange()`. There was previously a class like that in the codepipeline-actions module, but it was marked experimental, and had some strong opinions on the construction way of the subclasses (required passing the `actionProperties` through a `super()` call in the constructor, which is not very flexible). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an officially supported class to the API of the CodePipeline module
that contains some logic common to all implementations of the
IActioninterface,like dealing with variable namespaces, or methods like
onStateChange().There was previously a class like that in the codepipeline-actions module,
but it was marked experimental, and had some strong opinions on the construction way of the subclasses
(required passing the
actionPropertiesthrough asuper()call in the constructor,which is not very flexible).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license