fix(codepipeline): detect the account of the Action from its backing resource's account, not its Stack's account #14224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resource's account, not its Stack's account In CodePipeline, Actions can have a resource backing it (like an S3 Bucket, or an ECS Service). In the CodePipeline construct however, the account a given action was in was incorrectly determined by checking the Stack of the backing resource, instead of the resource itself. This value can be different for imported resources. Fixes aws#14165
|
|
github-actions
bot
added
the
@aws-cdk/aws-codepipeline
This was referenced Apr 16, 2021
rix0rrr
approved these changes
Apr 19, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
…resource's account, not its Stack's account (aws#14224) In CodePipeline, Actions can have a resource backing it (like an S3 Bucket, or an ECS Service). In the CodePipeline construct however, the account a given action was in was incorrectly determined by checking the Stack of the backing resource, instead of the resource itself. This value can be different for imported resources. Fixes aws#14165 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CodePipeline, Actions can have a resource backing it (like an S3 Bucket, or an ECS Service).
In the CodePipeline construct however,
the account a given action was in was incorrectly determined by checking the Stack of the backing resource,
instead of the resource itself.
This value can be different for imported resources.
Fixes #14165
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license