Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(s3): urlForObject does not consider explicit bucket region #14315

Merged
merged 2 commits into from
May 3, 2021
Merged

fix(s3): urlForObject does not consider explicit bucket region #14315

merged 2 commits into from
May 3, 2021

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Apr 22, 2021 •
edited by iliapolo
Loading

This commit updates urlForObject() to use the bucket's region instead of the stack's region when constructing the returned URL.

Fixes #14149

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@cjihrig
fix(s3): use bucket's region in urlForObject()
ef0b169 
This commit updates urlForObject() to use the bucket's region
instead of the stack's region when constructing the returned
URL.

Refs: aws#14149
@gitpod-io
Copy link

gitpod-io bot commented Apr 22, 2021

@github-actions github-actions bot added the @aws-cdk/aws-s3 Related to Amazon S3 label Apr 22, 2021
@cjihrig
Copy link
Contributor Author

cjihrig commented Apr 28, 2021

Friendly ping @iliapolo.

@peterwoodworth peterwoodworth self-assigned this Apr 30, 2021
peterwoodworth
peterwoodworth reviewed Apr 30, 2021
View reviewed changes
Copy link
Contributor

@peterwoodworth peterwoodworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this PR! It looks good to me, however I haven't had the time to fully verify that it works. I'll get to that on Monday and assuming the PR is good I'll merge it then.

@gitpod-io
Copy link

gitpod-io bot commented May 2, 2021

@iliapolo iliapolo changed the title fix(s3): use bucket's region in urlForObject() fix(s3): urlForObject does not consider explicit bucket region May 2, 2021
@iliapolo iliapolo added the pr/do-not-merge This PR should not be merged at this time. label May 2, 2021
iliapolo
iliapolo approved these changes May 2, 2021
View reviewed changes
Copy link
Contributor

@iliapolo iliapolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. @peterwoodworth I've added do-not-merge in case you still want to verify something here. Feel free to remove the label and let it merge.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: ce891ee
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@peterwoodworth peterwoodworth removed the pr/do-not-merge This PR should not be merged at this time. label May 3, 2021
@mergify
Copy link
Contributor

mergify bot commented May 3, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@peterwoodworth
Copy link
Contributor

Yup! it's good. Thank you for the contribution @cjihrig 😄

@mergify mergify bot merged commit e11d537 into aws:master May 3, 2021
@cjihrig cjihrig deleted the urlforobject branch May 3, 2021 12:49
john-tipper pushed a commit to john-tipper/aws-cdk that referenced this pull request May 10, 2021
@cjihrig @john-tipper
fix(s3): urlForObject does not consider explicit bucket region (aws#1…
035b97d 
…4315)

This commit updates `urlForObject()` to use the bucket's region instead of the stack's region when constructing the returned URL.

Fixes aws#14149

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@cjihrig @hollanddd
fix(s3): urlForObject does not consider explicit bucket region (aws#1…
17a4cfb 
…4315)

This commit updates `urlForObject()` to use the bucket's region instead of the stack's region when constructing the returned URL.

Fixes aws#14149

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterwoodworth peterwoodworth peterwoodworth approved these changes

@iliapolo iliapolo iliapolo approved these changes

Assignees

@iliapolo iliapolo

@peterwoodworth peterwoodworth

Labels
@aws-cdk/aws-s3 Related to Amazon S3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-s3): urlForObject() returns invalid URL if bucket is not in same region as stack
4 participants
@cjihrig @aws-cdk-automation @peterwoodworth @iliapolo