Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDS Proxy uses id instead of uniqueId for the Proxy name #14374

Closed
dave-graham opened this issue Apr 26, 2021 · 2 comments
Closed

RDS Proxy uses id instead of uniqueId for the Proxy name #14374

dave-graham opened this issue Apr 26, 2021 · 2 comments
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/large Large work item – several weeks of effort p1

Comments

@dave-graham
Copy link

dave-graham commented Apr 26, 2021

When a DatabaseProxy is created, the default id appears to take the id of the resource when dbProxyName isn't specified. This generates a non unique id, meaning that if we were to spin up another stack with the same id, we would have a clash. Is there a way to generate the id to be unique as default, as is the case for many other constructs?

Reproduction Steps

this.proxy = this.database.addProxy("Proxy", {
        maxConnectionsPercent: 100,
        secrets: [this.database.secret],
        vpcSubnets: {
          subnetType,
        },
        vpc,
        securityGroups: [rDSPostgresSecurityGroup],
      });

What did you expect to happen?

Cloud formation id of Proxykhsf98bsj

What actually happened?

Cloud formation id of Proxy

This is 🐛 Bug Report

@dave-graham dave-graham added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Apr 26, 2021
@github-actions github-actions bot added the @aws-cdk/aws-rds Related to Amazon Relational Database label Apr 26, 2021
@skinny85 skinny85 changed the title aws-rds: short issue description RDS Proxy uses id instead of uniqueId for the Proxy name Apr 26, 2021
@skinny85
Copy link
Contributor

Thanks for opening the issue @dave-graham. You are correct, this is a bug in the RDS library.

To unblock yourself, you can always pass an explicit dbProxyName property when calling addProxy.

@skinny85 skinny85 added effort/large Large work item – several weeks of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels Apr 26, 2021
@github-actions
Copy link

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/large Large work item – several weeks of effort p1
Projects
None yet
Development

No branches or pull requests

2 participants