fix(cfn-include): correctly parse Fn::Sub expressions containing serialized JSON #14512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alized JSON
Our logic for parsing `${}` expressions inside `Fn::Sub` incorrectly looked for closing braces everywhere in the string,
instead of doing it to the right of the opening `${`.
This would fail if the string passed to `Fn::Sub` was serialized JSON
(as those would contain closing braces completely unrelated to the `${`).
Fixes aws#14095
|
|
github-actions
bot
added
the
@aws-cdk/cloudformation-include
rix0rrr
approved these changes
May 4, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
john-tipper
pushed a commit
to john-tipper/aws-cdk
that referenced
this pull request
May 10, 2021
…alized JSON (aws#14512) Our logic for parsing `${}` expressions inside `Fn::Sub` incorrectly looked for closing braces everywhere in the string, instead of doing it to the right of the opening `${`. This would fail if the string passed to `Fn::Sub` was serialized JSON (as those would contain closing braces completely unrelated to the `${`). Fixes aws#14095 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
…alized JSON (aws#14512) Our logic for parsing `${}` expressions inside `Fn::Sub` incorrectly looked for closing braces everywhere in the string, instead of doing it to the right of the opening `${`. This would fail if the string passed to `Fn::Sub` was serialized JSON (as those would contain closing braces completely unrelated to the `${`). Fixes aws#14095 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our logic for parsing
${}expressions insideFn::Subincorrectly looked for closing braces everywhere in the string,instead of doing it to the right of the opening
${.This would fail if the string passed to
Fn::Subwas serialized JSON(as those would contain closing braces completely unrelated to the
${).Fixes #14095
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license