Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda-nodejs): non-deterministic runtime version #14538

Merged
merged 2 commits into from
May 5, 2021

Conversation

jogold
Copy link
Contributor

@jogold jogold commented May 5, 2021

Use NODEJS_14_X as default runtime for NodejsFunction.

Closes #13893

BREAKING CHANGE: the default runtime version for NodejsFunction is now always NODEJS_14_X (previously the version was derived from the local NodeJS runtime and could be either 12.x or 14.x).


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Use `NODEJS_14_X` as default runtime.

Closes aws#13893
@gitpod-io
Copy link

gitpod-io bot commented May 5, 2021

@jogold
Copy link
Contributor Author

jogold commented May 5, 2021

@eladb this is somewhat breaking? and the less likely breaking option is to use NODEJS_14_X which is the most installed version now?

should be documented as a BREAKING CHANGE?

@mergify
Copy link
Contributor

mergify bot commented May 5, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@eladb
Copy link
Contributor

eladb commented May 5, 2021

@jogold I am okay with this change. Node 14.x is mostly compatible with Node 12.x, so I hope this change will unlikely break existing users.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: d91346e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 527f662 into aws:master May 5, 2021
@mergify
Copy link
Contributor

mergify bot commented May 5, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

john-tipper pushed a commit to john-tipper/aws-cdk that referenced this pull request May 10, 2021
Use `NODEJS_14_X` as default runtime for `NodejsFunction`.

Closes aws#13893

BREAKING CHANGE: the default runtime version for `NodejsFunction` is now always `NODEJS_14_X` (previously the version was derived from the local NodeJS runtime and could be either 12.x or 14.x).

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
Use `NODEJS_14_X` as default runtime for `NodejsFunction`.

Closes aws#13893

BREAKING CHANGE: the default runtime version for `NodejsFunction` is now always `NODEJS_14_X` (previously the version was derived from the local NodeJS runtime and could be either 12.x or 14.x).

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(lambda-nodejs): non-deterministic runtime version
3 participants