-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lambda-nodejs): non-deterministic runtime version #14538
Conversation
Use `NODEJS_14_X` as default runtime. Closes aws#13893
@eladb this is somewhat breaking? and the less likely breaking option is to use should be documented as a BREAKING CHANGE? |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
@jogold I am okay with this change. Node 14.x is mostly compatible with Node 12.x, so I hope this change will unlikely break existing users. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Use `NODEJS_14_X` as default runtime for `NodejsFunction`. Closes aws#13893 BREAKING CHANGE: the default runtime version for `NodejsFunction` is now always `NODEJS_14_X` (previously the version was derived from the local NodeJS runtime and could be either 12.x or 14.x). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Use `NODEJS_14_X` as default runtime for `NodejsFunction`. Closes aws#13893 BREAKING CHANGE: the default runtime version for `NodejsFunction` is now always `NODEJS_14_X` (previously the version was derived from the local NodeJS runtime and could be either 12.x or 14.x). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Use
NODEJS_14_X
as default runtime forNodejsFunction
.Closes #13893
BREAKING CHANGE: the default runtime version for
NodejsFunction
is now alwaysNODEJS_14_X
(previously the version was derived from the local NodeJS runtime and could be either 12.x or 14.x).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license