fix: assert matches more than the template on multiple CDK copies
#14544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `assert` library sometimes fails to get the template out of a `CloudFormationStackArtifact` if there are multiple copies of the CDK in the dependency tree. Fix by replacing an `instanceof` with a duck-type check. Fixes #14468.
|
|
github-actions
bot
added
the
@aws-cdk/assert
eladb
approved these changes
May 5, 2021
rix0rrr
added
the
pr-linter/exempt-test
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
john-tipper
pushed a commit
to john-tipper/aws-cdk
that referenced
this pull request
May 10, 2021
…ws#14544) The `assert` library sometimes fails to get the template out of a `CloudFormationStackArtifact` if there are multiple copies of the CDK in the dependency tree. Fix by replacing an `instanceof` with a duck-type check. Fixes aws#14468. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
…ws#14544) The `assert` library sometimes fails to get the template out of a `CloudFormationStackArtifact` if there are multiple copies of the CDK in the dependency tree. Fix by replacing an `instanceof` with a duck-type check. Fixes aws#14468. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
assertlibrary sometimes fails to get the template out of aCloudFormationStackArtifactif there are multiple copies of the CDK inthe dependency tree.
Fix by replacing an
instanceofwith a duck-type check.Fixes #14468.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license