-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Parameterize bootstrap stack version #14626
feat: Parameterize bootstrap stack version #14626
Conversation
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
Fixes Issue #14313 |
@rabbittsoup thanks for this contribution! Could you please add a description which explains the motivation for this change and the approach you have taken, so we can prioritize this for review? |
Original post edited. |
I have a feeling I just recently approved the exact same change in a different PR? Or am I going batty? In any case, there are conflicts to resolve now, sorry. |
The other approved change was for v2, this is v1. |
Conflicts resolved |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
The hard coding of the cdk version ssm parameter limits custom bootstrap configurations. In a managed account environment, the naming may not conform to environment requirements, preventing cdk bootstrap deployment. By also allowing the parameter name to be customized, multiple bootstrap stacks could exist in the same environment, which can enable more granular management of the bootstrap resources. This implementation resolves the issue by allowing the ssm parameter name to be customized through the same mechanism as other default/modern synthesizer parameters. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
The hard coding of the cdk version ssm parameter limits custom bootstrap configurations. In a managed account environment, the naming may not conform to environment requirements, preventing cdk bootstrap deployment. By also allowing the parameter name to be customized, multiple bootstrap stacks could exist in the same environment, which can enable more granular management of the bootstrap resources.
This implementation resolves the issue by allowing the ssm parameter name to be customized through the same mechanism as other default/modern synthesizer parameters.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license