Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Parameterize bootstrap stack version #14626

Merged
merged 5 commits into from
Jun 7, 2021
Merged

feat: Parameterize bootstrap stack version #14626

merged 5 commits into from
Jun 7, 2021

Conversation

rabbittsoup
Copy link
Contributor

@rabbittsoup rabbittsoup commented May 10, 2021

The hard coding of the cdk version ssm parameter limits custom bootstrap configurations. In a managed account environment, the naming may not conform to environment requirements, preventing cdk bootstrap deployment. By also allowing the parameter name to be customized, multiple bootstrap stacks could exist in the same environment, which can enable more granular management of the bootstrap resources.

This implementation resolves the issue by allowing the ssm parameter name to be customized through the same mechanism as other default/modern synthesizer parameters.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 10, 2021

@mergify
Copy link
Contributor

mergify bot commented May 10, 2021

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@rabbittsoup rabbittsoup changed the title Parameterize bootstrap stack version feat: Parameterize bootstrap stack version May 10, 2021
@rabbittsoup
Copy link
Contributor Author

Fixes Issue #14313

@eladb
Copy link
Contributor

eladb commented May 20, 2021

@rabbittsoup thanks for this contribution! Could you please add a description which explains the motivation for this change and the approach you have taken, so we can prioritize this for review?

@rabbittsoup
Copy link
Contributor Author

Original post edited.

@rix0rrr
Copy link
Contributor

rix0rrr commented Jun 4, 2021

I have a feeling I just recently approved the exact same change in a different PR? Or am I going batty?

In any case, there are conflicts to resolve now, sorry.

@rabbittsoup
Copy link
Contributor Author

The other approved change was for v2, this is v1.

@rabbittsoup
Copy link
Contributor Author

Conflicts resolved

rix0rrr
rix0rrr previously approved these changes Jun 7, 2021
@mergify mergify bot dismissed rix0rrr’s stale review June 7, 2021 08:41

Pull request has been modified.

@rix0rrr rix0rrr added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes labels Jun 7, 2021
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 388f0e8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit a37108c into aws:master Jun 7, 2021
@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@rabbittsoup rabbittsoup deleted the parameterize_bootstrap_stack_version branch June 14, 2021 13:41
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
The hard coding of the cdk version ssm parameter limits custom bootstrap configurations.  In a managed account environment, the naming may not conform to environment requirements, preventing cdk bootstrap deployment.  By also allowing the parameter name to be customized, multiple bootstrap stacks could exist in the same environment, which can enable more granular management of the bootstrap resources.

This implementation resolves the issue by allowing the ssm parameter name to be customized through the same mechanism as other default/modern synthesizer parameters.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants