fix(stepfunctions): repeated object references not allowed even if not a circular reference #14628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be allowed if not causing a circular reference fixes aws#14596
|
|
github-actions
bot
added
the
@aws-cdk/aws-stepfunctions
shivlaks
changed the title
BenChaimberg
changed the title
BenChaimberg
previously approved these changes
Jun 7, 2021
mergify
bot
dismissed
BenChaimberg’s stale review
Pull request has been modified.
BenChaimberg
approved these changes
Jun 7, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
…t a circular reference (aws#14628) Popping the current node from `visited` array after finishing visiting it in `recurseObject` method. This allows another reference to the same object to happen on a different object path (currently being swallowed). Created unit test before making any code changes to verify the failure scenario on the expected behavior before fixing it. fixes aws#14596 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Popping the current node from
visitedarray after finishing visiting it inrecurseObjectmethod. This allows another reference to the same object to happen on a different object path (currently being swallowed).Created unit test before making any code changes to verify the failure scenario on the expected behavior before fixing it.
fixes #14596
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license