Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecs): Adding support for ECS Exec #14670

Merged
merged 29 commits into from
Jun 3, 2021

Conversation

upparekh
Copy link
Contributor

@upparekh upparekh commented May 13, 2021

Fixes #13618

This PR adds support for ECS exec command. It adds necessary IAM permissions for the AWS Systems Manager (SSM) to enable exec and also adds IAM permissions for allowing the exec command result logs to be routed to either CloudWatch logs/ S3 Bucket or both.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@upparekh upparekh self-assigned this May 13, 2021
@gitpod-io
Copy link

gitpod-io bot commented May 13, 2021

@upparekh upparekh linked an issue May 13, 2021 that may be closed by this pull request
2 tasks
@mergify
Copy link
Contributor

mergify bot commented May 13, 2021

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@SoManyHs SoManyHs self-requested a review May 13, 2021 00:38
@SoManyHs SoManyHs added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label May 13, 2021
@SoManyHs SoManyHs changed the title Adding support for ECS Exec feat(ecs): Adding support for ECS Exec May 13, 2021
@upparekh upparekh added the pr/work-in-progress This PR is a draft and needs further work. label May 13, 2021
@upparekh upparekh marked this pull request as draft May 13, 2021 01:00
@upparekh upparekh marked this pull request as ready for review May 19, 2021 22:07
@upparekh upparekh requested a review from iamhopaul123 May 19, 2021 22:07
Copy link
Contributor

@iamhopaul123 iamhopaul123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so good! Can't believe this is happening!

packages/@aws-cdk/aws-ecs/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs/lib/cluster.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs/lib/cluster.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs/lib/cluster.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs/lib/cluster.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs/lib/cluster.ts Outdated Show resolved Hide resolved
@upparekh upparekh requested review from bvtujo and iamhopaul123 May 21, 2021 22:29
Copy link
Contributor

@SoManyHs SoManyHs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so great! Just a few small nits for things like wording and style, but otherwise LGTM!! 🎉

packages/@aws-cdk/aws-ecs/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs/lib/base/base-service.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs/lib/cluster.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs/lib/cluster.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs/lib/cluster.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs/lib/cluster.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs/lib/cluster.ts Outdated Show resolved Hide resolved
Co-authored-by: Hsing-Hui Hsu <hsinghui@amazon.com>
iamhopaul123
iamhopaul123 previously approved these changes Jun 2, 2021
Copy link
Contributor

@iamhopaul123 iamhopaul123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! You might want to manually test its main functionalities and address Hsinghui's feedback before merging the PR. But other than those I'll ship it 🚢

@iamhopaul123 iamhopaul123 added the pr/do-not-merge This PR should not be merged at this time. label Jun 2, 2021
@mergify mergify bot dismissed iamhopaul123’s stale review June 2, 2021 23:55

Pull request has been modified.

@upparekh upparekh requested a review from SoManyHs June 3, 2021 00:08
SoManyHs
SoManyHs previously approved these changes Jun 3, 2021
Copy link
Contributor

@SoManyHs SoManyHs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mergify mergify bot dismissed SoManyHs’s stale review June 3, 2021 19:41

Pull request has been modified.

SoManyHs
SoManyHs previously approved these changes Jun 3, 2021
@SoManyHs SoManyHs removed pr/do-not-merge This PR should not be merged at this time. pr/work-in-progress This PR is a draft and needs further work. labels Jun 3, 2021
@mergify mergify bot dismissed SoManyHs’s stale review June 3, 2021 20:28

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 880a2a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@upparekh upparekh requested a review from SoManyHs June 3, 2021 21:34
@mergify mergify bot merged commit b35328c into aws:master Jun 3, 2021
@mergify
Copy link
Contributor

mergify bot commented Jun 3, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

iliapolo added a commit that referenced this pull request Jun 7, 2021
@ghost ghost mentioned this pull request Jun 18, 2021
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
Fixes aws#13618

This PR adds support for ECS exec command. It adds necessary IAM permissions for the AWS Systems Manager (SSM) to enable exec and also adds IAM permissions for allowing the exec command result logs to be routed to either CloudWatch logs/ S3 Bucket or both.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-ecs): ECS Exec Support
4 participants