feat(ecs-patterns): Add Load Balancer name to ApplicationLoadBalancedFargateService props #14831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the loadbalancer name to the props so we can customise the LB name rather than having a random generated LB name
|
|
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
Add extra example to the readme to show the changes in the PR
Add a new test to cover the changes in the PR
richardhughes
changed the title
richardhughes
changed the title
Add extra comma and remove back ticks
Fix the quotes and trailing commas
|
is there any way to work around this? |
peterwoodworth
added
the
@aws-cdk/aws-ecs-patterns
SoManyHs
reviewed
Jun 9, 2021
| @@ -523,3 +523,21 @@ new QueueProcessingFargateService(stack, 'QueueProcessingService', { | |||
| image: new ecs.AssetImage(path.join(__dirname, '..', 'sqs-reader')), | |||
| }); | |||
| ``` | |||
|
|
|||
| ### Select specific load balancer name ApplicationLoadBalancedFargateService | |||
There was a problem hiding this comment.
Suggested change
| ### Select specific load balancer name ApplicationLoadBalancedFargateService | |
| ### Specify load balancer name for an ApplicationLoadBalancedFargateService |
SoManyHs
approved these changes
Jun 9, 2021
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
…FargateService props (aws#14831) This PR allows the loadbalancer name to be passed to the ApplicationLoadBalancedFargateService. This PR just exposes a prop from the ApplicationLoadBalancer construct. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the loadbalancer name to be passed to the ApplicationLoadBalancedFargateService. This PR just exposes a prop from the ApplicationLoadBalancer construct.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license