feat(assets): exclude "cdk.out" from docker assets #14842
Conversation
|
|
Co-authored-by: Elad Ben-Israel <benisrae@amazon.com>
peterwoodworth
added
the
@aws-cdk/aws-ecr-assets
We can include it in this PR if you are inclined. |
|
@AlexGue are you interested in continuing to work on this PR or should we close for now? |
Yes, hopefully I have some time during this week to solve it. |
|
Hey @AlexGue thanks for following up on this. I wanted to make sure you are aware that you can run Let me know if you need help to get this across the finish line. |
Thanks for the comment, I was unaware. I tried to run the command to update the assets regarding aws-lambda-python package, but it seems to fail. (I am doing this directly on Gitpod):
Maybe Gitpod is not able to build docker images, or am I missing something? |
|
@AlexGue not sure you can mount volumes in Gitpod... integrate this commit jogold@f3140f8 and you should be good. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
@AlexGue how are we doing here? Need help? |
|
Superseded by #16034 |
This PR is intended to cover a small bug that creates an infinite loop generating folders in cdk.out if the project root path is specified as the build directory. With this fix 'cdk.out' folder will be added as glob exclude pattern no matters what. More details in issue #14841 Original PR from @AlexGue Closes #14841 Closes #14842 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This PR is intended to cover a small bug that creates an infinite loop generating folders in cdk.out if the project root path is specified as the build directory. With this fix 'cdk.out' folder will be added as glob exclude pattern no matters what. More details in issue aws#14841 Original PR from @AlexGue Closes aws#14841 Closes aws#14842 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This PR is intended to cover a small bug that creates an infinite loop generating folders in cdk.out if the project root path is specified as the build directory. With this fix 'cdk.out' folder will be added as glob exclude pattern no matters what. More details in issue aws#14841 Original PR from @AlexGue Closes aws#14841 Closes aws#14842 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This PR is intended to cover a small bug that creates an infinite loop generating folders in cdk.out if the project root path is specified as the build directory. With this fix 'cdk.out' folder will be added as glob exclude pattern no matters what. More details in issue aws#14841 Original PR from @AlexGue Closes aws#14841 Closes aws#14842 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This PR is intended to cover a small bug that creates an infinite loop generating folders in cdk.out if the project root path is specified as the build directory.
With this fix 'cdk.out' folder will be added as glob exclude pattern no matters what.
More details in issue #14841
Closes #14841
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license