Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): new bootstrap supports cross-account lookups #14874

Merged
merged 9 commits into from
Jun 3, 2021
Merged

feat(cli): new bootstrap supports cross-account lookups #14874

merged 9 commits into from
Jun 3, 2021

Conversation

otaviomacedo
Copy link
Contributor

@otaviomacedo otaviomacedo commented May 26, 2021

Fixes #8905


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 26, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 26, 2021
@otaviomacedo otaviomacedo marked this pull request as ready for review June 1, 2021 10:13
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: f55cb57
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rix0rrr rix0rrr changed the title feat(cli): cross-account lookups feat(cli): new bootstrap creates role for cross-account lookups Jun 3, 2021
@rix0rrr rix0rrr changed the title feat(cli): new bootstrap creates role for cross-account lookups feat(cli): new bootstrap supports cross-account lookups Jun 3, 2021
@rix0rrr rix0rrr added the pr/do-not-merge This PR should not be merged at this time. label Jun 3, 2021
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks!

@rix0rrr rix0rrr removed the pr/do-not-merge This PR should not be merged at this time. label Jun 3, 2021
@mergify mergify bot merged commit f66f4b8 into aws:master Jun 3, 2021
@mergify
Copy link
Contributor

mergify bot commented Jun 3, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mrpackethead
Copy link

What is this role called?

@mrpackethead
Copy link

This change appears to be causing me considerable greif!!

My pipeline buiids are crashing, using v1.108

@BenChaimberg
Copy link
Contributor

@mrpackethead please open a new issue with details of the problem and we'll try to help you out!

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
Fixes aws#8905

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support cross-account context queries from bootstrap stack
6 participants