Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(cli): cdk --all deploys hidden stage stacks not displayed with cdk diff --all #14898

Closed
McDoit opened this issue May 27, 2021 · 3 comments
Closed
Assignees
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p1 package/tools Related to AWS CDK Tools or CLI

Comments

@McDoit
Copy link
Contributor

McDoit commented May 27, 2021

Running cdk deploy --all deploys stacks in stages, not visible when running cdk diff --all

Related to this feature: #14379

Reproduction Steps

const app = new cdk.App()

// Stage allows us to synth CF template for Stacks added to it
const stage = new cdk.Stage(app, "Stage")
new StackToDeployAsStackset(stage, "XYZ")
const stackSetTemplateObj = stage.synth().stacks[0].template

const stackSetDeployer = new cdk.Stack(app, "StackSetDeployer")
new cdk.CfnStackSet(stackSetDeployer, "XYZASaStackSet", {
            ...
            templateBody: JSON.stringify(stackSetTemplateObj),
})

This creates both a stackset, but also the hidden stack deployment of XYZ

What did you expect to happen?

Following the discussion about cdk and stacksets, creating a stage with a stack and synthing the stage to use that stack artifact with cloudformation stacksets, and with a stage, the stack shouldnt be deployed locally

Or at least visible in in the diff if this was intentional

What actually happened?

The deploy command deploys the stack from the stage, and the diff command didn't even display that this would happen

Environment

  • CDK CLI Version : 1.106.1
  • Framework Version: 1.106.1
  • Node.js Version: v15.8.0
  • OS : Windows
  • Language (Version): all

Other

Related to this feature: #14379


This is 🐛 Bug Report

@McDoit McDoit added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels May 27, 2021
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label May 27, 2021
@McDoit McDoit changed the title (cli): cdk --all deploys hidden stage stacks not displayed in diff (cli): cdk --all deploys hidden stage stacks not displayed with cdk diff --all May 27, 2021
@rix0rrr
Copy link
Contributor

rix0rrr commented Jun 4, 2021

That should not happen, thanks for reporting.

@rix0rrr rix0rrr added effort/small Small work item – less than a day of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels Jun 4, 2021
@rix0rrr rix0rrr assigned otaviomacedo and unassigned rix0rrr Jun 4, 2021
@otaviomacedo
Copy link
Contributor

Fixed by #15046.

@github-actions
Copy link

github-actions bot commented Jun 9, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p1 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants