Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cfnspec): cloudformation spec v37.1.0 #14951

Merged
merged 5 commits into from
Jun 7, 2021
Merged

Conversation

aws-cdk-automation
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation commented Jun 2, 2021

BREAKING CHANGE: imageScanningConfiguration property of ecr.CfnRepository now accepts scanOnPush instead of ScanOnPush (notice the casing change).

@aws-cdk-automation aws-cdk-automation added pr-linter/exempt-test The PR linter will not require test changes pr/auto-approve Notifies the GH action to auto-approve this PR labels Jun 2, 2021
@gitpod-io
Copy link

gitpod-io bot commented Jun 2, 2021

@iliapolo iliapolo added the pr/do-not-merge This PR should not be merged at this time. label Jun 3, 2021
github-actions[bot]
github-actions bot previously approved these changes Jun 3, 2021
@mergify mergify bot dismissed github-actions[bot]’s stale review June 3, 2021 11:19

Pull request has been modified.

github-actions[bot]
github-actions bot previously approved these changes Jun 3, 2021
@mergify mergify bot dismissed github-actions[bot]’s stale review June 3, 2021 14:07

Pull request has been modified.

@njlynch njlynch enabled auto-merge June 7, 2021 09:57
@njlynch njlynch disabled auto-merge June 7, 2021 09:59
github-actions[bot]
github-actions bot previously approved these changes Jun 7, 2021
@mergify mergify bot dismissed github-actions[bot]’s stale review June 7, 2021 13:57

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: b251fce
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@iliapolo iliapolo removed the pr/do-not-merge This PR should not be merged at this time. label Jun 7, 2021
@mergify mergify bot merged commit aee0f58 into master Jun 7, 2021
@mergify mergify bot deleted the bump-cfnspec/v37.1.0 branch June 7, 2021 16:07
@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
BREAKING CHANGE: `imageScanningConfiguration` property of `ecr.CfnRepository` now accepts `scanOnPush` instead of `ScanOnPush` (notice the casing change).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/auto-approve Notifies the GH action to auto-approve this PR pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants