Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for VPC link between APIGW and Fargate Service #1500

Closed
dotxlem opened this issue Jan 8, 2019 · 3 comments · Fixed by #1541
Closed

Support for VPC link between APIGW and Fargate Service #1500

dotxlem opened this issue Jan 8, 2019 · 3 comments · Fixed by #1541
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container

Comments

@dotxlem
Copy link
Contributor

dotxlem commented Jan 8, 2019

I've implemented some changes in a fork to allow using API Gateway as a proxy to a Fargate service. I wanted to check here first if this is something that could be pushed back upstream, and if so how to go about it properly.

There are changes to both aws-apigateway and aws-ecs, and I wasn't sure whether it was fine to make changes to both in the same PR if they're related.

API Gateway Changes
Added connectionType to the IntegrationOptions, to allow specifying VPC_LINK.
Added requestParameters to the MethodOptions to allow setting proxy path variable.

ECS Changes
For LoadBalancedFargateService:

  • Added loadBalancerType prop to allow specifying a Network Load Balancer.
  • Added containerEnvironment prop to allow passing environment variables to the container.

I'm not using it personally, but for completeness it wouldn't be much effort to do the same for the LoadBalancedEcsService.

@rix0rrr
Copy link
Contributor

rix0rrr commented Jan 9, 2019

I would love to pull those changes upstream!

I would insist that you make the same changes to LoadBalancedEcsService though, and also please don't forget to include tests!

@rix0rrr rix0rrr added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Jan 9, 2019
@rix0rrr
Copy link
Contributor

rix0rrr commented Jan 9, 2019

cc @SoManyHs

@dotxlem
Copy link
Contributor Author

dotxlem commented Jan 9, 2019

Great! I'll aim to get a PR up sometime later this week, assuming it doesn't take me too long to write tests and update LoadBalancedEcsService.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants