-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(DynamoDB): Enabling ContributorInsights (boolean flag) does not reflect in child/related resources (like GSIs and replication regions) #15080
Comments
Hey @arnab, thanks for opening the issue.
Thanks, |
Thanks for the response, @skinny85 !
I think you will need to make this a property of |
If this was directly modelled as a wrapper around a CloudFormation resource, it would have made sense to request it as a feature from CloudFormation. From what I get, Since it's a different API-calls, I would expect CDK to also follow the Or do we need additional support from DynamoDB for it? |
Love it! Any chance you could submit us a PR with this change @arnab? Our "Contributing" guide is here: https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md. |
It's implemented as a Custom Resource, yes, because CloudFormation support was not added until very, very recently. We will need to switch to the new CloudFormation resources at some point, and deprecate the current Custom Resource-based implementation. However, I still don't see the new resource having the option to enable ContributorInsights.
The problem is the API call that we use, which is |
Hmmm unfortunately, I won't be able to contribute to the solution at this time :( Happy to provide any discussion/feedback if you need though.
I see. It appears that there is a different API for enabling Since CDK is making an API call to create the replica region, if the |
Hard to argue with that logic 🙂. |
This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled. |
It’s not resolved, so please keep it open. |
CDK's support for DynamoDB's ContributorInsights feature is enabled via a simple boolean flag: Table#contributorInsightsEnabled.
However, turning on this single boolean field does not turn on ContributorInsights in child/related resources, such as:
Use Case
If
ContributorInsights
is enabled via a single boolean field (like it is right now), it yields a nice simple user-experience. But I expect it to also enable it on related resources.Otherwise, I expect to have other ways of enabling it on such child/related resources directly, but there does not appear to be any way to do this (aside from a CustomResource).
Proposed Solution
Either:
ContributorInsights
on all child resources (part of theTable
)GSI
and perreplicatedRegion
).Other
Original discussion and Pull-Request:
[DynamoDb]: Add support DynamoDb Contributer Insights #11626
feat(dynamodb): add ability to enable contributor insights on Table #14742
👋 I may be able to implement this feature request
This is a 🚀 Feature Request
The text was updated successfully, but these errors were encountered: