Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cfnspec): cloudformation spec v39.3.0 #15311

Merged
merged 4 commits into from
Jun 25, 2021
Merged

Conversation

aws-cdk-automation
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation commented Jun 25, 2021

No description provided.

@aws-cdk-automation aws-cdk-automation added pr-linter/exempt-test The PR linter will not require test changes pr/auto-approve Notifies the GH action to auto-approve this PR labels Jun 25, 2021
@gitpod-io
Copy link

gitpod-io bot commented Jun 25, 2021

github-actions[bot]
github-actions bot previously approved these changes Jun 25, 2021
@mergify mergify bot dismissed github-actions[bot]’s stale review June 25, 2021 08:51

Pull request has been modified.

rix0rrr
rix0rrr previously approved these changes Jun 25, 2021
github-actions[bot]
github-actions bot previously approved these changes Jun 25, 2021
@mergify mergify bot dismissed stale reviews from github-actions[bot] and rix0rrr June 25, 2021 09:12

Pull request has been modified.

github-actions[bot]
github-actions bot previously approved these changes Jun 25, 2021
@mergify mergify bot dismissed github-actions[bot]’s stale review June 25, 2021 09:39

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: a7629f4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 94eb3a8 into master Jun 25, 2021
@mergify mergify bot deleted the bump-cfnspec/v39.3.0 branch June 25, 2021 10:19
@mergify
Copy link
Contributor

mergify bot commented Jun 25, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

skinny85 added a commit to skinny85/aws-cdk that referenced this pull request Jul 13, 2021
…ion type

A recent update to the SAM spec (aws#15311)
changed the EndpointConfiguration property of AWS::Serverless::Api
to have a complex type.
However, that is a breaking change compared to the previous, string, type.
I consulted with the SAM team, and it turns out the property accepts both a string and the complex type.
Given that, patch our SAM spec to make EndpointConfiguration a union type.
skinny85 added a commit to skinny85/aws-cdk that referenced this pull request Jul 14, 2021
…ion type

A recent update to the SAM spec (aws#15311)
changed the EndpointConfiguration property of AWS::Serverless::Api
to have a complex type.
However, that is a breaking change compared to the previous, string, type.
I consulted with the SAM team, and it turns out the property accepts both a string and the complex type.
Given that, patch our SAM spec to make EndpointConfiguration a union type.
mergify bot pushed a commit that referenced this pull request Jul 15, 2021
…ion type (#15526)

A recent update to the SAM spec (#15311)
changed the EndpointConfiguration property of AWS::Serverless::Api to have a complex type.
However, that is a breaking change compared to the previous, string, type.
I consulted with the SAM team, and it turns out the property accepts both a string and the complex type.
Given that, patch our SAM spec to make EndpointConfiguration a union type.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Aug 3, 2021
…ion type (aws#15526)

A recent update to the SAM spec (aws#15311)
changed the EndpointConfiguration property of AWS::Serverless::Api to have a complex type.
However, that is a breaking change compared to the previous, string, type.
I consulted with the SAM team, and it turns out the property accepts both a string and the complex type.
Given that, patch our SAM spec to make EndpointConfiguration a union type.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
* feat: cloudformation spec v39.3.0

* Add patch to work around wonky SAM spec update

* pkglint fix

* Ignore awslint error

Co-authored-by: AWS CDK Team <aws-cdk@amazon.com>
Co-authored-by: Rico Huijbers <rix0rrr@gmail.com>
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
…ion type (aws#15526)

A recent update to the SAM spec (aws#15311)
changed the EndpointConfiguration property of AWS::Serverless::Api to have a complex type.
However, that is a breaking change compared to the previous, string, type.
I consulted with the SAM team, and it turns out the property accepts both a string and the complex type.
Given that, patch our SAM spec to make EndpointConfiguration a union type.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/auto-approve Notifies the GH action to auto-approve this PR pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants