fix(aws-ecs): token is added to Options instead of SecretOptions in SplunkLogDriver #15408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
upparekh
added
@aws-cdk/aws-ecs
iamhopaul123
previously approved these changes
Jul 6, 2021
mergify
bot
dismissed
iamhopaul123’s stale review
Pull request has been modified.
madeline-k
reviewed
Jul 7, 2021
madeline-k
previously requested changes
Jul 7, 2021
madeline-k
changed the title
upparekh
force-pushed
the
upparekh/secret-token-for-splunk
branch
from
659ceaf to
1b9adf4
Compare
upparekh
force-pushed
the
upparekh/secret-token-for-splunk
branch
from
1b9adf4 to
e2c7f85
Compare
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Aug 3, 2021
…plunkLogDriver (aws#15408) ---- This PR closes [aws#7264](aws#7264). The `token` field of the Splunk log driver populates the `Options` property of the Log Configuration which leads to the secret being resolved to its value on deploying, and then the token is viewable in plain text in the console and may be stored in plain text elsewhere. Thus, we are deprecating the `token` field of the Splunk log driver and are introducing a new `secretToken` field. `secretToken` can be used to provide the Splunk token as a Secrets Manager Secret or a Systems Manager Parameter and will be populated in the `SecretOptions` property of the Log Configuration. *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
…plunkLogDriver (aws#15408) ---- This PR closes [aws#7264](aws#7264). The `token` field of the Splunk log driver populates the `Options` property of the Log Configuration which leads to the secret being resolved to its value on deploying, and then the token is viewable in plain text in the console and may be stored in plain text elsewhere. Thus, we are deprecating the `token` field of the Splunk log driver and are introducing a new `secretToken` field. `secretToken` can be used to provide the Splunk token as a Secrets Manager Secret or a Systems Manager Parameter and will be populated in the `SecretOptions` property of the Log Configuration. *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #7264.
The
tokenfield of the Splunk log driver populates theOptionsproperty of the Log Configuration which leads to the secret being resolved to its value on deploying, and then the token is viewable in plain text in the console and may be stored in plain text elsewhere. Thus, we are deprecating thetokenfield of the Splunk log driver and are introducing a newsecretTokenfield.secretTokencan be used to provide the Splunk token as a Secrets Manager Secret or a Systems Manager Parameter and will be populated in theSecretOptionsproperty of the Log Configuration.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license