Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lambda): cloudwatch lambda insights #15439

Merged
merged 37 commits into from
Jul 29, 2021

Conversation

flemjame-at-amazon
Copy link
Contributor

@flemjame-at-amazon flemjame-at-amazon commented Jul 6, 2021

Closes #12489

This allows a user to configure Lambda Insights and have the relevant IAM policy be added to the Lambda role.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jul 6, 2021

@peterwoodworth peterwoodworth added the @aws-cdk/aws-lambda Related to AWS Lambda label Jul 6, 2021
packages/@aws-cdk/aws-lambda/README.md Show resolved Hide resolved
packages/@aws-cdk/aws-lambda/README.md Outdated Show resolved Hide resolved
@nija-at nija-at added effort/small Small work item – less than a day of effort p2 labels Jul 15, 2021
@nija-at nija-at added effort/medium Medium work item – several days of effort and removed effort/small Small work item – less than a day of effort labels Jul 16, 2021
@mergify mergify bot dismissed nija-at’s stale review July 20, 2021 19:23

Pull request has been modified.

@flemjame-at-amazon
Copy link
Contributor Author

@nija-at I think the latest is more or less in line with your recommendations for user experience. The only area I can think of for improvement is to auto-generate the LambdaInsightsVersion public static readonly members.

https://github.com/aws/aws-cdk/pull/15439/files#diff-203458110222061ed1f54590e8556cf107bfa77c6da383e05f955491045e33faR18-R33

Is there a way to auto-generate these versions from the Fact Tables ?

Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delayed review.

This looks great! Thanks for making these changes.
See some of my comments below. Nothing major.

packages/@aws-cdk/aws-lambda/lib/lambda-insights.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-lambda/lib/lambda-insights.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-lambda/lib/lambda-insights.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-lambda/lib/lambda-insights.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-lambda/test/lambda-insights.test.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-lambda/test/lambda-insights.test.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-lambda/test/lambda-insights.test.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed nija-at’s stale review July 29, 2021 14:09

Pull request has been modified.

Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor docs and other updates to polish it up.

Looks great.

packages/@aws-cdk/aws-lambda/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-lambda/lib/function.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-lambda/package.json Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-lambda/test/lambda-insights.test.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-lambda/test/lambda-insights.test.ts Outdated Show resolved Hide resolved
@nija-at nija-at changed the title feat(lambda): Lambda insights integration feat(lambda): cloudwatch lambda insights Jul 29, 2021
@mergify mergify bot dismissed nija-at’s stale review July 29, 2021 15:48

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Jul 29, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: a7f09b9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 9efd800 into aws:master Jul 29, 2021
@mergify
Copy link
Contributor

mergify bot commented Jul 29, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@flemjame-at-amazon flemjame-at-amazon deleted the lambda-insights-integration branch July 29, 2021 18:29
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Aug 3, 2021
Closes aws#12489

This allows a user to configure Lambda Insights and have the relevant IAM policy be added to the Lambda role.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
Closes aws#12489

This allows a user to configure Lambda Insights and have the relevant IAM policy be added to the Lambda role.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-lambda Related to AWS Lambda effort/medium Medium work item – several days of effort p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(lambda): Lambda insights functionality
4 participants