-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lambda): cloudwatch lambda insights #15439
feat(lambda): cloudwatch lambda insights #15439
Conversation
…me-at-amazon/aws-cdk into lambda-insights-integration
@nija-at I think the latest is more or less in line with your recommendations for user experience. The only area I can think of for improvement is to auto-generate the Is there a way to auto-generate these versions from the Fact Tables ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delayed review.
This looks great! Thanks for making these changes.
See some of my comments below. Nothing major.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor docs and other updates to polish it up.
Looks great.
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Closes aws#12489 This allows a user to configure Lambda Insights and have the relevant IAM policy be added to the Lambda role. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Closes aws#12489 This allows a user to configure Lambda Insights and have the relevant IAM policy be added to the Lambda role. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Closes #12489
This allows a user to configure Lambda Insights and have the relevant IAM policy be added to the Lambda role.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license