Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecs): add support for Bottlerocket on ARM64 #15454

Merged
merged 2 commits into from
Aug 23, 2021

Conversation

otterley
Copy link
Contributor

@otterley otterley commented Jul 7, 2021

Add support for Bottlerocket AMIs on ARM64 architecture, including AWS Graviton2 instances.

Closes #14466


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jul 7, 2021

@otterley otterley force-pushed the ecs-bottlerocket-arm64 branch 2 times, most recently from 4489b47 to 727b00d Compare July 7, 2021 20:34
@peterwoodworth peterwoodworth added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Jul 7, 2021
Copy link
Contributor

@upparekh upparekh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @otterley , the PR looks good! Can you please resolve the conflicts in the files?

@otterley otterley force-pushed the ecs-bottlerocket-arm64 branch from 727b00d to 037cd97 Compare August 21, 2021 21:21
@otterley
Copy link
Contributor Author

Hi @otterley , the PR looks good! Can you please resolve the conflicts in the files?

Done!

Copy link
Contributor

@upparekh upparekh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify
Copy link
Contributor

mergify bot commented Aug 23, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 4b70e91
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit cd280a8 into aws:master Aug 23, 2021
@mergify
Copy link
Contributor

mergify bot commented Aug 23, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
Add support for Bottlerocket AMIs on ARM64 architecture, including AWS Graviton2 instances. 

Closes aws#14466 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Sep 6, 2021
Add support for Bottlerocket AMIs on ARM64 architecture, including AWS Graviton2 instances. 

Closes aws#14466 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this pull request Sep 7, 2021
Add support for Bottlerocket AMIs on ARM64 architecture, including AWS Graviton2 instances. 

Closes aws#14466 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-eks): Support bottlerocket arm64 AMI's
7 participants