Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ecr-assets): There is already a Construct with name 'Staging' when using tarball image #15540

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Jul 14, 2021

Use this and not scope for the scope of AssetStaging in
TarballImageAsset.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…n using tarball image

Use `this` and not `scope` for the scope of `AssetStaging` in
`TarballImageAsset`.
@gitpod-io
Copy link

gitpod-io bot commented Jul 14, 2021

@jogold
Copy link
Contributor Author

jogold commented Jul 14, 2021

@eladb

@jogold
Copy link
Contributor Author

jogold commented Jul 14, 2021

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 783d0b0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 594d7c6 into aws:master Jul 14, 2021
@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@jogold jogold deleted the tarball-this-scope branch July 14, 2021 17:48
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Aug 3, 2021
…n using tarball image (aws#15540)

Use `this` and not `scope` for the scope of `AssetStaging` in
`TarballImageAsset`.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
…n using tarball image (aws#15540)

Use `this` and not `scope` for the scope of `AssetStaging` in
`TarballImageAsset`.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants