Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(custom-resources): assumedRole from AwsCustomResource invocation leaked to next execution #15776

Merged
merged 4 commits into from
Dec 13, 2021

Conversation

theipster
Copy link
Contributor

Fixes #15425

Credit to @nicolai-shape for proposing the fix itself.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jul 27, 2021

@peterwoodworth peterwoodworth added the @aws-cdk/custom-resources Related to AWS CDK Custom Resources label Jul 28, 2021
@nija-at nija-at added effort/small Small work item – less than a day of effort p1 labels Aug 5, 2021
@nicolai-shape
Copy link

Any news on when this will be merged? 😊

@theipster
Copy link
Contributor Author

theipster commented Sep 27, 2021

Bump, can one of the reviewers/maintainers review this please?

The bug is labelled as a p1, it's still relevant, and it's evidently causing problems for multiple users. It's also been 2 months since this PR was first opened.

Happy to take on any feedback that gets presented. 😃

@nicolai-shape
Copy link

Would love to have this merged...

@theipster theipster force-pushed the custom-resources-credentials-leakage branch from 16a05ce to ab038ab Compare December 7, 2021 23:11
@theipster
Copy link
Contributor Author

From CONTRIBUTING.md:

Once the pull request is submitted, a reviewer will be assigned by the maintainers.

Can a reviewer be assigned to this please?

rix0rrr
rix0rrr previously approved these changes Dec 9, 2021
@rix0rrr rix0rrr changed the title fix(custom-resources): stop persisting credentials across AwsCustomResource invocations fix(custom-resources): assumedRole from AwsCustomResource invocation leaked to next execution Dec 9, 2021
@theipster
Copy link
Contributor Author

The AWS CodeBuild check seems to be "waiting" for quite some time. Is there something that can be done to speed this up?

@mergify mergify bot dismissed rix0rrr’s stale review December 13, 2021 16:23

Pull request has been modified.

@skinny85
Copy link
Contributor

The AWS CodeBuild check seems to be "waiting" for quite some time. Is there something that can be done to speed this up?

Re-kicked the build 🙂.

@mergify
Copy link
Contributor

mergify bot commented Dec 13, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: be4d598
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit e138188 into aws:master Dec 13, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 13, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…leaked to next execution (aws#15776)

Fixes aws#15425

Credit to @nicolai-shape for proposing the fix itself.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/custom-resources Related to AWS CDK Custom Resources effort/small Small work item – less than a day of effort p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(custom-resources): AwsCustomResource leaks assumed role to other custom resources
7 participants