Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cognito): user pools - device tracking #16055

Merged
merged 3 commits into from
Aug 24, 2021
Merged

feat(cognito): user pools - device tracking #16055

merged 3 commits into from
Aug 24, 2021

Conversation

emilrowland
Copy link
Contributor

fixes #15013

This pull request adds the support of device configuration for Cognito user pools. DeviceConfiguration

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Aug 14, 2021

@peterwoodworth peterwoodworth added @aws-cdk/aws-cognito Related to Amazon Cognito effort/small Small work item – less than a day of effort p2 labels Aug 19, 2021
@nija-at nija-at changed the title feat(aws-cognito): added support for device configuration feat(cognito): user pools - device tracking Aug 24, 2021
nija-at
nija-at previously requested changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks mostly good. Just one comment.

packages/@aws-cdk/aws-cognito/lib/user-pool.ts Outdated
* Device tracking settings
* @see https://docs.aws.amazon.com/cognito/latest/developerguide/amazon-cognito-user-pools-device-tracking.html
*/
export interface DeviceConfiguration {
Copy link
Contributor

@nija-at nija-at Aug 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're using Settings as the suffix, like EmailSettings. Can we use DeviceSettings instead?

Alternatively, would DeviceTracking be more suitable? (Is challengeRequiredOnNewDevice part of device tracking?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have renamed DeviceConfiguration to DeviceTracking.
Regarding challengeRequiredOnNewDevice that is a part of the deviceConfiguration spec: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cognito-userpool-deviceconfiguration.html#cfn-cognito-userpool-deviceconfiguration-challengerequiredonnewdevice

@mergify mergify bot dismissed nija-at’s stale review August 24, 2021 13:29

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: fca875c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 64019bb into aws:master Aug 24, 2021
@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@emilrowland @hollanddd
feat(cognito): user pools - device tracking (aws#16055)
0fde072 
fixes aws#15013

This pull request adds the support of device configuration for Cognito user pools. [DeviceConfiguration](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cognito-userpool-deviceconfiguration.html)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Sep 6, 2021
@emilrowland @TikiTDO
feat(cognito): user pools - device tracking (aws#16055)
7e7a0fa 
fixes aws#15013

This pull request adds the support of device configuration for Cognito user pools. [DeviceConfiguration](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cognito-userpool-deviceconfiguration.html)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this pull request Sep 7, 2021
@emilrowland @david-doyle-as24
feat(cognito): user pools - device tracking (aws#16055)
2047fca 
fixes aws#15013

This pull request adds the support of device configuration for Cognito user pools. [DeviceConfiguration](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cognito-userpool-deviceconfiguration.html)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nija-at nija-at nija-at approved these changes

Assignees

@nija-at nija-at

Labels
@aws-cdk/aws-cognito Related to Amazon Cognito effort/small Small work item – less than a day of effort p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(cognito user pools): support for setting rules for user devices
4 participants
@emilrowland @aws-cdk-automation @nija-at @peterwoodworth