-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lambda): nodejs14.x supports inline code #16131
Conversation
@gkaskonas can you link to the docs where it says this? thanks |
People are saying that it is working now aws-cloudformation/cloudformation-coverage-roadmap#80 |
Looks good to me, but I'll let @nija-at take a look first |
This is not good enough. Can you update the test here and run a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting the status to 'request changes' to address the comment above.
@nija-at I have added an integration test for nodejs14 runtime. I was able to deploy that function in my AWS account and it returned:
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Cloudformation now supports Inline code for NodeJS14 runtime. Updating CDK to reflect that ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Cloudformation now supports Inline code for NodeJS14 runtime. Updating CDK to reflect that ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Cloudformation now supports Inline code for NodeJS14 runtime. Updating CDK to reflect that ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Cloudformation now supports Inline code for NodeJS14 runtime. Updating CDK to reflect that
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license