Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lambda): nodejs14.x supports inline code #16131

Merged
merged 4 commits into from
Aug 24, 2021

Conversation

gkaskonas
Copy link
Contributor

Cloudformation now supports Inline code for NodeJS14 runtime. Updating CDK to reflect that


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Aug 19, 2021

@peterwoodworth
Copy link
Contributor

@gkaskonas can you link to the docs where it says this? thanks

@peterwoodworth peterwoodworth self-assigned this Aug 19, 2021
@peterwoodworth peterwoodworth added effort/small Small work item – less than a day of effort @aws-cdk/aws-lambda Related to AWS Lambda labels Aug 19, 2021
@gkaskonas
Copy link
Contributor Author

People are saying that it is working now aws-cloudformation/cloudformation-coverage-roadmap#80

@peterwoodworth peterwoodworth changed the title feat: enable nodejs14 inlineCode feat(lambda): enable nodejs14 inlineCode Aug 19, 2021
@peterwoodworth peterwoodworth added the pr-linter/exempt-test The PR linter will not require test changes label Aug 19, 2021
@peterwoodworth
Copy link
Contributor

Looks good to me, but I'll let @nija-at take a look first

@nija-at
Copy link
Contributor

nija-at commented Aug 23, 2021

People are saying that it is working now aws-cloudformation/cloudformation-coverage-roadmap#80

This is not good enough.

Can you update the test here and run a cdk deploy --app test/integ.runtime.inlinecode.js to see that it succeeds?

@nija-at nija-at added the pr-linter/exempt-readme The PR linter will not require README changes label Aug 23, 2021
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting the status to 'request changes' to address the comment above.

@mergify mergify bot dismissed nija-at’s stale review August 24, 2021 13:01

Pull request has been modified.

@gkaskonas
Copy link
Contributor Author

@nija-at I have added an integration test for nodejs14 runtime.

I was able to deploy that function in my AWS account and it returned:

aws lambda invoke --function-name aws-cdk-lambda-runtime-inlinecod-NODEJS14X930214A3-cGZMHuS8Evt4         --profile dev --region us-east-1  std
{
    "StatusCode": 200,
    "ExecutedVersion": "$LATEST"
}
giedriuskaskonas@Giedriuss-MacBook-Pro tests % cat std
"success"%

@gkaskonas gkaskonas requested a review from nija-at August 24, 2021 13:16
@nija-at nija-at changed the title feat(lambda): enable nodejs14 inlineCode feat(lambda): nodejs14.x supports inline code Aug 24, 2021
@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 9d87307
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 305f683 into aws:master Aug 24, 2021
@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
Cloudformation now supports Inline code for NodeJS14 runtime. Updating CDK to reflect that

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Sep 6, 2021
Cloudformation now supports Inline code for NodeJS14 runtime. Updating CDK to reflect that

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this pull request Sep 7, 2021
Cloudformation now supports Inline code for NodeJS14 runtime. Updating CDK to reflect that

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-lambda Related to AWS Lambda effort/small Small work item – less than a day of effort pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants