fix(lambda-python): docker image gets built even when we don't need to bundle assets #16192
Conversation
|
|
RomainMuller
force-pushed
the
master
branch
from
924c117
to
ebfd5f2
Compare
peterwoodworth
changed the title
|
@jihndai are you still able to work on this PR? If you are able to fix the conflicts I can review and approve. |
corymhall
added
the
response-requested
|
This PR has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled. |
github-actions
bot
added
the
closing-soon
|
@corymhall Sure, sorry this fell out of my radar for such a long time. I'll push some updates within a week or so. |
github-actions
bot
removed
closing-soon
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…o bundle assets (aws#16192) `DockerImage.fromBuild` was being called for bundling regardless of whether the stack needed bundling or not. With this change, we will check if the stack needs bundling before proceeding to build the docker image. Fixes aws#14747 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
DockerImage.fromBuildwas being called for bundling regardless of whether the stack needed bundling or not. With this change, we will check if the stack needs bundling before proceeding to build the docker image.Fixes #14747
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license