Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: temporarily transfer @skinny85 module ownership #16206

Merged
merged 5 commits into from
Aug 25, 2021
Merged

revert: temporarily transfer @skinny85 module ownership #16206

merged 5 commits into from
Aug 25, 2021

Conversation

BenChaimberg
Copy link
Contributor

This reverts commit 77dfa2f.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@BenChaimberg BenChaimberg requested review from skinny85, madeline-k and a team August 24, 2021 15:31
@gitpod-io
Copy link

gitpod-io bot commented Aug 24, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 24, 2021
skinny85
skinny85 approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BenChaimberg!

@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@BenChaimberg BenChaimberg enabled auto-merge (squash) August 24, 2021 17:31
@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@BenChaimberg BenChaimberg merged commit e678f10 into master Aug 25, 2021
@BenChaimberg BenChaimberg deleted the chaimber/revert_temp_adam_issue_assign branch August 25, 2021 12:51
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 2c768ed
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@BenChaimberg @hollanddd
revert: temporarily transfer @skinny85 module ownership (aws#16206)
3495f6e 
This reverts commit 77dfa2f.
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Sep 6, 2021
@BenChaimberg @TikiTDO
revert: temporarily transfer @skinny85 module ownership (aws#16206)
c37605d 
This reverts commit 77dfa2f.
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this pull request Sep 7, 2021
@BenChaimberg @david-doyle-as24
revert: temporarily transfer @skinny85 module ownership (aws#16206)
4daad67 
This reverts commit 77dfa2f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skinny85 skinny85 skinny85 approved these changes

@madeline-k madeline-k Awaiting requested review from madeline-k

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenChaimberg @aws-cdk-automation @skinny85