fix(core): SecretValue.secretsManager fails for tokenized secret-id #16230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The example which was provided in the issue can be deployed after this fix. In addition, I tested the change using the following code for const param = new cdk.CfnParameter(this, 'MyParam', {
default: 'foo',
});
const secretValueFoo = cdk.SecretValue.secretsManager(param.valueAsString).toString();
new ssm.StringParameter(this, 'string-parameter-foo', {stringValue: secretValueFoo}); |
RomainMuller
force-pushed
the
master
branch
from
924c117 to
ebfd5f2
Compare
peterwoodworth
changed the title
rix0rrr
approved these changes
Oct 27, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…ws#16230) `SecretValue.secretsManager` fails if a token is used for `secret-id`. This is caused by a validation which should be skipped for tokenized values. Solved by skipping the validation if token is unresolved. Fixes aws#16166. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SecretValue.secretsManagerfails if a token is used forsecret-id. This is caused by a validation which should be skipped for tokenized values.Solved by skipping the validation if token is unresolved.
Fixes #16166.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license