-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stepfunctions-tasks): await the eval so async ops can be passed to tasks.EvaluateExpression #16290
feat(stepfunctions-tasks): await the eval so async ops can be passed to tasks.EvaluateExpression #16290
Conversation
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
Thanks for your contribution! Can you just give me an example of such an asynchronous operation? |
@BenChaimberg absolutely! here is a snippet I have in my step function which is currently not possible without this patch:
The addition of the |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…to tasks.EvaluateExpression (aws#16290) Currently the way `EvaluateExpression` is set up, if you pass an async expression to it, it never waits for the execution to complete. By adding an `await` before the `eval()` call, async ops can be passed in. This also works for sync ops same as before (await works with sync code as well). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…to tasks.EvaluateExpression (aws#16290) Currently the way `EvaluateExpression` is set up, if you pass an async expression to it, it never waits for the execution to complete. By adding an `await` before the `eval()` call, async ops can be passed in. This also works for sync ops same as before (await works with sync code as well). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This change seems to have been reverted by this commit. Was this intentional? |
Currently the way
EvaluateExpression
is set up, if you pass an async expression to it, it never waits for the execution to complete. By adding anawait
before theeval()
call, async ops can be passed in. This also works for sync ops same as before (await works with sync code as well).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license