feat(lambda-nodejs): custom asset hash

[jogold]

By default the asset hash for a NodejsFunction is based on the
bundling output, the result of the esbuild bundling.

Add a assetHash prop to customize the asset hash and allow users to
implement their own logic. This can be useful if users want to invalidate
the asset based on specific (input) file contents or logic.

Closes #16157

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[jogold]

@nija-at can you check this? thx!

[nija-at]

@jogold - can you update the PR description with more details on what is going on here and why this is needed?

I couldn't fully understand it from the linked issue.

[jogold]

@jogold - can you update the PR description with more details on what is going on here and why this is needed?

I couldn't fully understand it from the linked issue.

updated

[nija-at]

I'm still not following the motivation.

What is a use case for this? Why would we want to provide such an option?
Why is updating our current hash calculation not enough?

It feels that this is going to be used incorrectly more often than correctly, and thereby users are going to shoot themselves in the foot.

[jogold]

What is a use case for this? Why would we want to provide such an option?

@oyed can you detail your use case here?

One use case I can think of: you don't want the hash to change if the way esbuild bundles changes, e.g. for the same input files and dependencies the content of the resulting index.js is different but functionally remains the same. This can happen after an update of esbuild for example.

Identifying the specific input files of a NodejsFunction is almost impossible to achieve in the construct itself. The idea of the NodejsFunction is to allow users to mix infra and runtime code, so we don't know what is the "source".

It feels that this is going to be used incorrectly more often than correctly, and thereby users are going to shoot themselves in the foot.

We're just exposing an asset option from core which allows to do this. aws-lambda-go and aws-lambda-python are already exposing this.

[eladb]

LGTM

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Pull request has been modified.

Pull request has been modified.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
• Commit ID: b0e07f5
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).