(aws-ecs): configFileValue should be optional in FirelensOptions

[dan-lind]

configFileValue is defined as a required value in FirelensOptions

Reproduction Steps

configFileValue should be marked as optional here

aws-cdk/packages/@aws-cdk/aws-ecs/lib/firelens-log-router.ts

Line 64 in 7966f8d

readonly configFileValue: string;

What did you expect to happen?

I expect that a config like this example for Datadog is valid
https://github.com/aws-samples/amazon-ecs-firelens-examples/blob/mainline/examples/fluent-bit/datadog/task-definition.json

What actually happened?

Above config doesn't work since configFileValue is mandatory.

Environment

• **Framework Version: v1.124

---

I'd be happy to provide an MR for this

This is 🐛 Bug Report

[marcelmindemann]

I would like to raise awareness for this bug again. We are running into it, and the workaround is quite a lot of effort and also costly. All we want to do is disabling ECS metadata addition, but setting this option on the FirelensOptions then requires filling configFileValue aswell. This means that instead of simply using the AWS-provided FireLens image and the auto-generated config, one has to

1. create their own fluentbit config file
2. bake that into their custom fluentbit image
3. build a CI pipeline to push config changes to ECR

[PettitWesley]

Fixed via this: #20636

[PettitWesley]

I think it only made it into CDK v2 tho: https://github.com/aws/aws-cdk/releases/tag/v2.34.0

[PettitWesley]

@kaizencc Can you close this issue? I lack perms.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.