Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): deployment progress shows stack name #16604

Merged
merged 7 commits into from
Oct 27, 2021

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Sep 22, 2021

Allows to filter logs based on stack name, gives more context
when looking at a log line in a log file.

Useful in CI when multiple stacks are deployed in a run.

(similar to lerna adding the package name)


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Allows to filter logs based on stack name. Useful in CI when multiple
stacks are deployed in a run.
@gitpod-io
Copy link

gitpod-io bot commented Sep 22, 2021

@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Oct 20, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@rix0rrr rix0rrr changed the title chore(cli): add stack name in stack activity monitor feat(cli): deployment progress shows stack name Oct 27, 2021
@rix0rrr rix0rrr added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes labels Oct 27, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: f059a70
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 322cf10 into aws:master Oct 27, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@jogold jogold deleted the stack-name-activity-monitor branch October 28, 2021 08:31
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
Allows to filter logs based on stack name, gives more context
when looking at a log line in a log file.

Useful in CI when multiple stacks are deployed in a run.

(similar to lerna adding the package name)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package/tools Related to AWS CDK Tools or CLI pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants