Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codebuild): add support for small ARM machine type #16635

Merged
merged 5 commits into from
Oct 14, 2021

Conversation

grusy
Copy link
Contributor

@grusy grusy commented Sep 24, 2021

closes #16633


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Sep 24, 2021

@skinny85 skinny85 self-assigned this Sep 24, 2021
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @grusy! We need to iron out a few minor details before we merge this in 🙂.

@skinny85 skinny85 added the pr-linter/exempt-readme The PR linter will not require README changes label Sep 24, 2021
@skinny85 skinny85 changed the title feat(aws-codebuild): support small ARM machine type feat(codebuild): add support for small ARM machine type Sep 24, 2021
@mergify mergify bot dismissed skinny85’s stale review September 24, 2021 20:28

Pull request has been modified.

skinny85
skinny85 previously approved these changes Oct 12, 2021
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @grusy!

@mergify mergify bot dismissed skinny85’s stale review October 12, 2021 21:34

Pull request has been modified.

@polothy
Copy link
Contributor

polothy commented Oct 14, 2021

@skinny85 I think mergify removed your approval? Sorry if I'm wrong, but we are interested in using these small ARM machines in our pipelines. Cheers!

Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skinny85 I think mergify removed your approval? Sorry if I'm wrong, but we are interested in using these small ARM machines in our pipelines. Cheers!

Stupid Mergify... approved again!

@mergify
Copy link
Contributor

mergify bot commented Oct 14, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: f1414e4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 55fbc86 into aws:master Oct 14, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 14, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
closes aws#16633 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-codebuild): support small ARM machine type
4 participants