Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lambda-nodejs): esbuild charset option #16726

Merged
merged 5 commits into from
Oct 29, 2021
Merged

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Sep 30, 2021

Support esbuild charset option.

Closes #16668


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Sep 30, 2021

nija-at
nija-at previously approved these changes Oct 29, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 29, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed nija-at’s stale review October 29, 2021 10:31

Pull request has been modified.

@jogold
Copy link
Contributor Author

jogold commented Oct 29, 2021

@nija-at had to fix a merge conflict here. Can you re-approve? Thx.

@mergify
Copy link
Contributor

mergify bot commented Oct 29, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: bcb256f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 56033a2 into aws:master Oct 29, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 29, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@jogold jogold deleted the nodejs-charset branch October 29, 2021 14:04
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
Support `esbuild` charset option.

Closes aws#16668


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-lambda-nodejs): support charset option
3 participants