Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Region Info: Cound not insert new fact from a Java process #16786

Closed
RomainMuller opened this issue Oct 4, 2021 · 3 comments
Closed

Region Info: Cound not insert new fact from a Java process #16786

RomainMuller opened this issue Oct 4, 2021 · 3 comments
Assignees
Labels
@aws-cdk/region-info Related to AWS Region information bug This issue is a bug. p1

Comments

@RomainMuller
Copy link
Contributor

What is the problem?

Attempting to register new Fact instances into the region info database is very inconvenient in Java, as a full-on implementation of an interface has to be rolled out (where a Struct would have been enough), and it also does not appear to work.

Reproduction Steps

Attempted to add a new custom class as an IFact implementation to the region info database - it did not appear to work.

What did you expect to happen?

Expected the fact to be registered and the behavior of the app to change according to that.

What actually happened?

The behavior of the app did not change.

CDK CLI Version

1.122.0

Framework Version

No response

Node.js Version

12.x

OS

Linux

Language

Java

Language Version

8

Other information

No response

@RomainMuller RomainMuller added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. @aws-cdk/region-info Related to AWS Region information p1 and removed needs-triage This issue or PR still needs to be triaged. labels Oct 4, 2021
@RomainMuller RomainMuller assigned RomainMuller and unassigned skinny85 Oct 4, 2021
@RomainMuller
Copy link
Contributor Author

So it turns out the reason why the custom fact was not used is because the stack that used it was likely "region-agnostic", so it could not use a registered fact and instead used the default value.

In this case, the proper avenues to address this are:

@rix0rrr
Copy link
Contributor

rix0rrr commented Feb 8, 2022

Closing this then.

@rix0rrr rix0rrr closed this as completed Feb 8, 2022
@github-actions
Copy link

github-actions bot commented Feb 8, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/region-info Related to AWS Region information bug This issue is a bug. p1
Projects
None yet
Development

No branches or pull requests

3 participants