Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ec2): add X2gd instances #16810

Merged
merged 3 commits into from
Oct 6, 2021
Merged

Conversation

jumic
Copy link
Contributor

@jumic jumic commented Oct 5, 2021

Add support for X2gd instances.

Announcement: https://aws.amazon.com/about-aws/whats-new/2021/03/announcing-new-amazon-ec2-x2gd-instances-powered-by-aws-graviton2-processors/

Closes #16794.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 5, 2021

@jumic
Copy link
Contributor Author

jumic commented Oct 5, 2021

Deployment tested successfully in region us-east-1:

new ec2.Instance(this, 'MyInstance', {
  vpc,
  instanceType: ec2.InstanceType.of(ec2.InstanceClass.X2GD, ec2.InstanceSize.MEDIUM),
  machineImage: new ec2.AmazonLinuxImage({
    generation: ec2.AmazonLinuxGeneration.AMAZON_LINUX_2,
    edition: ec2.AmazonLinuxEdition.STANDARD,
    virtualization: ec2.AmazonLinuxVirt.HVM,
    storage: ec2.AmazonLinuxStorage.GENERAL_PURPOSE,
    cpuType: ec2.AmazonLinuxCpuType.ARM_64,
  }),
});

Probably labels pr-linter/exempt-readme and pr-linter/exempt-test are necessary to merge this PR.

Copy link
Contributor

@peterwoodworth peterwoodworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping us updated!

@jumic
Copy link
Contributor Author

jumic commented Oct 6, 2021

@peterwoodworth Thanks for reviewing.
If nobody else has to approve this change, could you please add the labels mentioned above to merge this PR?

@peterwoodworth peterwoodworth added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes labels Oct 6, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 6, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: ca55a28
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 6d468d2 into aws:master Oct 6, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 6, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

njlynch pushed a commit that referenced this pull request Oct 11, 2021
Add support for X2gd instances.

Announcement: https://aws.amazon.com/about-aws/whats-new/2021/03/announcing-new-amazon-ec2-x2gd-instances-powered-by-aws-graviton2-processors/

Closes #16794.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
Add support for X2gd instances.

Announcement: https://aws.amazon.com/about-aws/whats-new/2021/03/announcing-new-amazon-ec2-x2gd-instances-powered-by-aws-graviton2-processors/

Closes aws#16794.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(module name): short issue description
3 participants