Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudwatch): alarms with accountId fails in regions that don't support cross-account alarms #16875

Merged
merged 11 commits into from
Oct 8, 2021
Merged

fix(cloudwatch): alarms with accountId fails in regions that don't support cross-account alarms #16875

merged 11 commits into from
Oct 8, 2021

Conversation

kaizencc
Copy link
Contributor

@kaizencc kaizencc commented Oct 8, 2021

Fixes #16874


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 8, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 8, 2021
@kaizencc kaizencc requested a review from eladb October 8, 2021 14:02
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: a96db4a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 54472a0 into aws:master Oct 8, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 8, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

njlynch pushed a commit that referenced this pull request Oct 11, 2021
…pport cross-account alarms (#16875)

Fixes #16874

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@kaizencc kaizencc deleted the fix/cloudwatch-alarms branch October 13, 2021 16:39
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…pport cross-account alarms (aws#16875)

Fixes aws#16874

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

‼️ (aws-cloudwatch): cross account alarms cause failures in unsupported regions
3 participants