Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3): enforce that fromBucketAttributes supplies a valid bucket name #16915

Merged
merged 9 commits into from
Nov 4, 2021

Conversation

berenddeboer
Copy link
Contributor


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 11, 2021

@peterwoodworth peterwoodworth changed the title fix: enforce that fromBucketAttributes supplies a valid bucket name fix(s3): enforce that fromBucketAttributes supplies a valid bucket name Oct 21, 2021
@github-actions github-actions bot added the @aws-cdk/aws-s3 Related to Amazon S3 label Oct 21, 2021
Copy link
Contributor

@otaviomacedo otaviomacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Can you just fix the failing tests, please?

@mergify
Copy link
Contributor

mergify bot commented Nov 3, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: cecd564
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 30ac0cc into aws:master Nov 4, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 4, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@berenddeboer berenddeboer deleted the fix/enforce-valid-bucket-name branch November 4, 2021 01:37
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…me (aws#16915)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-s3 Related to Amazon S3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants