Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(assertions): support assertions over nested stacks #16972

Merged
merged 7 commits into from
Nov 9, 2021

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented Oct 14, 2021

Add support for nested stacks


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@nija-at nija-at requested review from kaizencc and a team October 14, 2021 06:50
@nija-at nija-at self-assigned this Oct 14, 2021
@gitpod-io
Copy link

gitpod-io bot commented Oct 14, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 14, 2021
@nija-at nija-at added the pr-linter/exempt-readme The PR linter will not require README changes label Oct 14, 2021
@kaizencc kaizencc added the pr/do-not-merge This PR should not be merged at this time. label Oct 15, 2021
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the comment (about adding the comment). Otherwise looks good :) .

packages/@aws-cdk/assertions/lib/template.ts Show resolved Hide resolved
Co-authored-by: kaizen3031593 <36202692+kaizen3031593@users.noreply.github.com>
@nija-at nija-at removed the pr/do-not-merge This PR should not be merged at this time. label Oct 25, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 908d36f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit bde44e7 into master Nov 9, 2021
@mergify mergify bot deleted the nija-at/assertions-nested branch November 9, 2021 18:31
@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
Add support for nested stacks


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants