Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(opensearch): domain doesn't handle tokens in capacity configuration #17131

Merged
merged 2 commits into from
Nov 8, 2021

Conversation

jumic
Copy link
Contributor

@jumic jumic commented Oct 23, 2021

At the moment, tokens in OpenSearch capacity configuration lead to errors because they are not handled correctly for instance types. This fix provides the possibility to use tokens in instance types.

The changes are implemented in modules opensearch and elasticsearch.

Fixes #15014.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 23, 2021

@github-actions github-actions bot added the @aws-cdk/aws-opensearch Related to the @aws-cdk/aws-opensearchservice package label Oct 23, 2021
@kaizencc kaizencc added effort/small Small work item – less than a day of effort p1 labels Oct 25, 2021
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for the fix @jumic!

@mergify
Copy link
Contributor

mergify bot commented Nov 8, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 2627939 into aws:master Nov 8, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 8, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 11a5176
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…on (aws#17131)

At the moment, tokens in OpenSearch capacity configuration lead to errors because they are not handled correctly for instance types. This fix provides the possibility to use tokens in instance types.

The changes are implemented in modules opensearch and elasticsearch.

Fixes aws#15014.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@leantorres73
Copy link

I'm getting this error when trying to set dataNodeInstanceType and masterNodeInstanceType from SSM.

Incorrect format is used in the following SSM reference:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-opensearch Related to the @aws-cdk/aws-opensearchservice package effort/small Small work item – less than a day of effort p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(opensearch): domain doesn't handle tokens in capacity configuration
4 participants