Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eks): Allow passing of custom IAM role to Kube Ctl Lambda #17196

Merged
merged 9 commits into from
Nov 11, 2021

Conversation

pnathan-vr
Copy link
Contributor

@pnathan-vr pnathan-vr commented Oct 27, 2021

Adds the parameter kubectlLambdaRole? to the EKS Cluster construct. This IAM role gets passed to the cluster's KubeCtlProvider nested stack's lambda handler for running KubeCtl commands against the cluster.

@gitpod-io
Copy link

gitpod-io bot commented Oct 27, 2021

@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Oct 27, 2021
otaviomacedo
otaviomacedo previously approved these changes Nov 5, 2021
@otaviomacedo
Copy link
Contributor

Can you just add some documentation for this new property in the README?

Thanks.

@mergify mergify bot dismissed otaviomacedo’s stale review November 11, 2021 14:32

Pull request has been modified.

@pnathan-vr
Copy link
Contributor Author

@otaviomacedo - Done.

@mergify
Copy link
Contributor

mergify bot commented Nov 11, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 8fa293a into aws:master Nov 11, 2021
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: c642c4b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Nov 11, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@neelakansha85 neelakansha85 deleted the add-cluster-kubectl-role branch November 15, 2021 21:38
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…7196)

Adds the parameter `kubectlLambdaRole?` to the EKS `Cluster` construct. This IAM role gets passed to the cluster's `KubeCtlProvider` nested stack's lambda handler for running KubeCtl commands against the cluster.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants