fix(cli): no longer disable rollback by default for hotswap deployments #17317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would default the --rollback flag to `false` if it wasn't provided if the `--hotswap` option was also passed to `cdk deploy`. However, disabled rollback does not play well with deployments that cause replacements - they fail, and leave the Stack in a weird state. For that reason, stop disabling rollback by default. It's still possible to disable easily if wanted by using the `-R` switch. Fixes aws#17267
|
|
eladb
approved these changes
Nov 4, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…ts (aws#17317) Previously, we would default the `--rollback` flag to `false` if it wasn't explicitly provided if the `--hotswap` option was also passed to `cdk deploy`. However, disable rollback does not play well with deployments that cause replacements - they fail, and leave the Stack in a weird state. For that reason, stop disabling rollback by default. It's still possible to disable rollback easily if a customer wants to by using the `-R` switch. Fixes aws#17267 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would default the
--rollbackflag tofalseif it wasn't explicitly providedif the
--hotswapoption was also passed tocdk deploy.However, disable rollback does not play well with deployments that cause replacements -
they fail, and leave the Stack in a weird state.
For that reason, stop disabling rollback by default.
It's still possible to disable rollback easily if a customer wants to by using the
-Rswitch.Fixes #17267
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license